-
Notifications
You must be signed in to change notification settings - Fork 41.6k
kubeadm: added container runtime version check to preflight #134906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cri-api/README.md#v128
Checking RuntimeConfig is a little trick here. However, containerd version is not in cri info. I think this would be OK. |
|
This PR assumes that the container runtime is running on the node when we do init, join or upgrade operations. I'm unsure whether it is correct? If yes, I will add the same check for init/join operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, added a few minor comments.
yes, think we assume the container runtime is running before these commands are executed. |
best to also mention what actions the users need to take for what releases and what this config used for. |
d12c2e8 to
7ee55c6
Compare
Added a blog link in release note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i understand your point about 1.35.
this LGTM
/lgtm
|
LGTM label has been added. Git tree hash: fe850a255bc2d62e37fcce1592a8823a514c243a
|
|
The |
7ee55c6 to
b6aa354
Compare
Co-authored-by: Lubomir I. Ivanov <neolit123@gmail.com> Signed-off-by: carlory <baofa.fan@daocloud.io>
b6aa354 to
b3415bf
Compare
|
a known flaky test: #132956 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 7ddba2cc7b73c19db4b5b3e8d28ffe78e137d326
|
|
@carlory please check if the external kinder jobs (kubeadm-test) are going to show the warning. that will be an indication if we need to make some updates for the node images. also onhold if this is ready to merge. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR is related to:
Part of kubernetes/kubeadm#3229
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: