Skip to content

Commit a5638cf

Browse files
rwb27bprobert97
andauthored
Apply suggestions from code review
Co-authored-by: Beth <167304066+bprobert97@users.noreply.github.com>
1 parent 6695a51 commit a5638cf

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/old_dependency_tests/test_action_logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def test_unhandled_error_logs(caplog, client):
6868

6969

7070
def test_invocation_error_logs(caplog, client):
71-
"""Check that a log with a traceback is raised if there is an unhandled error."""
71+
"""Check that expected errors are logged without a traceback."""
7272
with caplog.at_level(logging.INFO, logger=THING_LOGGER.name):
7373
r = client.post("/log_and_error_thing/action_with_invocation_error")
7474
r.raise_for_status()

tests/old_dependency_tests/test_dependency_metadata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def test_fresh_metadata(client):
8484

8585
def test_fresh_metadata_deprecated(client):
8686
"""Test that the old metadata dependency retrieves fresh metadata."""
87-
r = client.post("/thing_two/count_and_watch")
87+
r = client.post("/thing_two/count_and_watch_deprecated")
8888
invocation = poll_task(client, r.json())
8989
assert invocation["status"] == "completed"
9090
out = invocation["output"]

0 commit comments

Comments
 (0)