fixed Feature name, fixed duplicated code

Author: rtschu

tests/behat/test_search.feature

@@ -1,5 +1,5 @@
 @mod @mod_moodleoverflow @mod_moodleoverflow_search
-Feature: Add moodleoverflow activities and discussions
+Feature: Search moodle for moodleoverflow discussions
   In order to find discussions
   I need to be able to search them
 
@@ -59,4 +59,4 @@ Feature: Add moodleoverflow activities and discussions
     And I fill in "id_q" with "Forum post 1"
     And I press "id_submitbutton"
     Then I should not see "Forum post 1"
-    And I should not see "This is the body"
+    And I should not see "This is the body"

tests/search_test.php

@@ -133,14 +133,15 @@ public function test_deleted_post() {
     public function test_forbidden_discussion() {
         global $CFG;
         $this->resetAfterTest();
+
         $CFG->enableglobalsearch = 1;
 
         $course = $this->getDataGenerator()->create_course();
-        $moodleoverflow = $this->getDataGenerator()->create_module("moodleoverflow", array("course" => $course));
         $moodleoverflowgen = $this->getDataGenerator()->get_plugin_generator('mod_moodleoverflow');
+        $moodleoverflow = $this->getDataGenerator()->create_module("moodleoverflow", array("course" => $course));
         $user = $this->getDataGenerator()->create_user();
-        $user2 = $this->getDataGenerator()->create_user();
         $this->getDataGenerator()->enrol_user($user->id, $course->id);
+        $user2 = $this->getDataGenerator()->create_user();
         $this->setUser($user2);
 
         [$discussion, $post] = $moodleoverflowgen->post_to_forum($moodleoverflow, $user);