codecleaning

Author: TamaroWalter

lib.php

@@ -92,6 +92,7 @@
  * @param int|null $courseid
  * @param int|null $gradecatid
  * @return int|null
+ * @throws dml_exception
  */
 function moodleoverflow_validate_grade_category(?int $courseid, ?int $gradecatid): ?int {
     global $DB;
@@ -114,27 +115,18 @@ function moodleoverflow_validate_grade_category(?int $courseid, ?int $gradecatid
  *
  * @return mixed true if the feature is supported, null if unknown
  */
-function moodleoverflow_supports($feature) {
+function moodleoverflow_supports(string $feature): mixed {
 
     if (defined('FEATURE_MOD_PURPOSE')) {
         if ($feature == FEATURE_MOD_PURPOSE) {
             return MOD_PURPOSE_COLLABORATION;
         }
     }
 
-    switch ($feature) {
-        case FEATURE_MOD_INTRO:
-            return true;
-        case FEATURE_SHOW_DESCRIPTION:
-            return true;
-        case FEATURE_BACKUP_MOODLE2:
-            return true;
-        case FEATURE_GRADE_HAS_GRADE:
-            return true;
-
-        default:
-            return null;
-    }
+    return match ($feature) {
+        FEATURE_MOD_INTRO, FEATURE_SHOW_DESCRIPTION, FEATURE_BACKUP_MOODLE2, FEATURE_GRADE_HAS_GRADE => true,
+        default => null,
+    };
 }
 
 /**
@@ -150,7 +142,7 @@ function moodleoverflow_supports($feature) {
  *
  * @return int The id of the newly inserted moodleoverflow record
  */
-function moodleoverflow_add_instance(stdClass $moodleoverflow, ?mod_moodleoverflow_mod_form $mform = null) {
+function moodleoverflow_add_instance(stdClass $moodleoverflow, ?mod_moodleoverflow_mod_form $mform = null): int {
     global $DB;
 
     // Set the current time.
@@ -174,7 +166,7 @@ function moodleoverflow_add_instance(stdClass $moodleoverflow, ?mod_moodleoverfl
  * Handle changes following the creation of a moodleoverflow instance.
  * This function is typically called by the course_module_created observer.
  *
- * @param object   $context        The context of the moodleoverflow
+ * @param context_module $context The context of the moodleoverflow
  * @param stdClass $moodleoverflow The moodleoverflow object
  */
 function moodleoverflow_instance_created(context_module $context, $moodleoverflow) {