Fix net graph message handler memory leaks.

Author: arik-so

bindings/LDK/Bindings.swift

@@ -6010,7 +6010,7 @@ public class Bindings {
 						}
 
 				return 
-				Result_PublicKeyErrorZ(pointer: recover_pk(msgWrapper.cOpaqueStruct!, Bindings.new_LDKStr(string: sig)))
+				Result_PublicKeyErrorZ(pointer: recover_pk(msgWrapper.cOpaqueStruct!, Bindings.new_LDKStr(string: sig, chars_is_owned: true)))
 
 
 	}
@@ -6023,7 +6023,7 @@ public class Bindings {
 						}
 
 				return 
-				verify(msgWrapper.cOpaqueStruct!, Bindings.new_LDKStr(string: sig), Bindings.new_LDKPublicKey(array: pk))
+				verify(msgWrapper.cOpaqueStruct!, Bindings.new_LDKStr(string: sig, chars_is_owned: true), Bindings.new_LDKPublicKey(array: pk))
 
 
 	}
@@ -6255,7 +6255,7 @@ withUnsafePointer(to: Bindings.array_to_tuple32(array: random_seed_bytes)) { (ra
 						}
 
 				return 
-				Result_InvoiceSignOrCreationErrorZ(pointer: create_phantom_invoice(amt_msat.danglingClone().cOpaqueStruct!, Bindings.new_LDKStr(string: description), Bindings.new_LDKThirtyTwoBytes(array: payment_hash), Bindings.new_LDKThirtyTwoBytes(array: payment_secret), phantom_route_hintsWrapper.dangle().cOpaqueStruct!, keys_manager.cOpaqueStruct!, network))
+				Result_InvoiceSignOrCreationErrorZ(pointer: create_phantom_invoice(amt_msat.danglingClone().cOpaqueStruct!, Bindings.new_LDKStr(string: description, chars_is_owned: true), Bindings.new_LDKThirtyTwoBytes(array: payment_hash), Bindings.new_LDKThirtyTwoBytes(array: payment_secret), phantom_route_hintsWrapper.dangle().cOpaqueStruct!, keys_manager.cOpaqueStruct!, network))
 
 
 	}
@@ -6282,7 +6282,7 @@ withUnsafePointer(to: Bindings.array_to_tuple32(array: random_seed_bytes)) { (ra
 
 				return withUnsafePointer(to: channelmanager.cOpaqueStruct!) { (channelmanagerPointer: UnsafePointer<LDKChannelManager>) in
 
-				Result_InvoiceSignOrCreationErrorZ(pointer: create_invoice_from_channelmanager(channelmanagerPointer, keys_manager.cOpaqueStruct!, network, amt_msat.danglingClone().cOpaqueStruct!, Bindings.new_LDKStr(string: description)))
+				Result_InvoiceSignOrCreationErrorZ(pointer: create_invoice_from_channelmanager(channelmanagerPointer, keys_manager.cOpaqueStruct!, network, amt_msat.danglingClone().cOpaqueStruct!, Bindings.new_LDKStr(string: description, chars_is_owned: true)))
 
 }
 
@@ -6312,7 +6312,7 @@ withUnsafePointer(to: Bindings.array_to_tuple32(array: random_seed_bytes)) { (ra
 
 				return withUnsafePointer(to: channelmanager.cOpaqueStruct!) { (channelmanagerPointer: UnsafePointer<LDKChannelManager>) in
 
-				Result_InvoiceSignOrCreationErrorZ(pointer: create_invoice_from_channelmanager_and_duration_since_epoch(channelmanagerPointer, keys_manager.cOpaqueStruct!, network, amt_msat.danglingClone().cOpaqueStruct!, Bindings.new_LDKStr(string: description), duration_since_epoch))
+				Result_InvoiceSignOrCreationErrorZ(pointer: create_invoice_from_channelmanager_and_duration_since_epoch(channelmanagerPointer, keys_manager.cOpaqueStruct!, network, amt_msat.danglingClone().cOpaqueStruct!, Bindings.new_LDKStr(string: description, chars_is_owned: true), duration_since_epoch))
 
 }
 
@@ -6429,7 +6429,7 @@ withUnsafePointer(to: Bindings.array_to_tuple32(array: random_seed_bytes)) { (ra
 	}
 	/* RUST_TO_SWIFT_END */
 
-    public class func LDKStr_to_string(nativeType: LDKStr) -> String {
+    public class func LDKStr_to_string(nativeType: LDKStr, deallocate: Bool = true) -> String {
 		var array = [UInt8]()
 		for index in 0..<Int(nativeType.len) {
 			let currentEntry = nativeType.chars[index]
@@ -6438,6 +6438,9 @@ withUnsafePointer(to: Bindings.array_to_tuple32(array: random_seed_bytes)) { (ra
 		}
 		let data = Data(bytes: array)
 		let string = String(data: data, encoding: .utf8)!
+		if deallocate && nativeType.len > 0{
+			Str_free(nativeType)
+		}
 		return string
 	}
 
@@ -6471,7 +6474,7 @@ withUnsafePointer(to: Bindings.array_to_tuple32(array: random_seed_bytes)) { (ra
 		let nativeKeysManager = keysManager.cOpaqueStruct!
 		let amount = Option_u64Z(value: amountMsat)
 		let nativeAmount = amount.cOpaqueStruct!
-		let nativeDescription = Self.new_LDKStr(string: description)
+		let nativeDescription = Self.new_LDKStr(string: description, chars_is_owned: true)
 		return withUnsafePointer(to: channelManager.cOpaqueStruct!) { (pointer: UnsafePointer<LDKChannelManager>) -> Result_InvoiceSignOrCreationErrorZ in
 			let nativeResult = create_invoice_from_channelmanager(pointer, nativeKeysManager, network, nativeAmount, nativeDescription)
 			return Result_InvoiceSignOrCreationErrorZ(pointer: nativeResult)
@@ -6490,7 +6493,7 @@ withUnsafePointer(to: Bindings.array_to_tuple32(array: random_seed_bytes)) { (ra
 	*/
 
 	public class func get_ldk_swift_bindings_version() -> String {
-        return "fe0ea5b41ca6eb7ef88a4d2fbd7dc1f647c89112"
+        return "2d6e99262b4c9728e43b7292a393e4100219a298"
     }
 
 }

bindings/LDK/options/APIError.swift

@@ -120,22 +120,22 @@ APIError_clone(origPointer)
 
     public class func apimisuse_error(err: String) -> APIError {
 
-        return APIError(pointer: APIError_apimisuse_error(Bindings.new_LDKStr(string: err)));
+        return APIError(pointer: APIError_apimisuse_error(Bindings.new_LDKStr(string: err, chars_is_owned: true)));
     }
 
     public class func fee_rate_too_high(err: String, feerate: UInt32) -> APIError {
 
-        return APIError(pointer: APIError_fee_rate_too_high(Bindings.new_LDKStr(string: err), feerate));
+        return APIError(pointer: APIError_fee_rate_too_high(Bindings.new_LDKStr(string: err, chars_is_owned: true), feerate));
     }
 
     public class func route_error(err: String) -> APIError {
 
-        return APIError(pointer: APIError_route_error(Bindings.new_LDKStr(string: err)));
+        return APIError(pointer: APIError_route_error(Bindings.new_LDKStr(string: err, chars_is_owned: true)));
     }
 
     public class func channel_unavailable(err: String) -> APIError {
 
-        return APIError(pointer: APIError_channel_unavailable(Bindings.new_LDKStr(string: err)));
+        return APIError(pointer: APIError_channel_unavailable(Bindings.new_LDKStr(string: err, chars_is_owned: true)));
     }
 
     public class func monitor_update_failed() -> APIError {

bindings/LDK/options/ClosureReason.swift

@@ -93,7 +93,7 @@ ClosureReason_clone(origPointer)
 
     public class func counterparty_force_closed(peer_msg: String) -> ClosureReason {
 
-        return ClosureReason(pointer: ClosureReason_counterparty_force_closed(Bindings.new_LDKStr(string: peer_msg)));
+        return ClosureReason(pointer: ClosureReason_counterparty_force_closed(Bindings.new_LDKStr(string: peer_msg, chars_is_owned: true)));
     }
 
     public class func holder_force_closed() -> ClosureReason {
@@ -118,7 +118,7 @@ ClosureReason_clone(origPointer)
 
     public class func processing_error(err: String) -> ClosureReason {
 
-        return ClosureReason(pointer: ClosureReason_processing_error(Bindings.new_LDKStr(string: err)));
+        return ClosureReason(pointer: ClosureReason_processing_error(Bindings.new_LDKStr(string: err, chars_is_owned: true)));
     }
 
     public class func disconnected_peer() -> ClosureReason {

bindings/LDK/options/ParseError.swift

@@ -190,7 +190,7 @@ ParseError_clone(origPointer)
 
     public class func invalid_slice_length(a: String) -> ParseError {
 
-        return ParseError(pointer: ParseError_invalid_slice_length(Bindings.new_LDKStr(string: a)));
+        return ParseError(pointer: ParseError_invalid_slice_length(Bindings.new_LDKStr(string: a, chars_is_owned: true)));
     }
 
     public class func skip() -> ParseError {

bindings/LDK/options/PaymentError.swift

@@ -102,7 +102,7 @@ PaymentError_clone(origPointer)
 
     public class func invoice(a: String) -> PaymentError {
 
-        return PaymentError(pointer: PaymentError_invoice(Bindings.new_LDKStr(string: a)));
+        return PaymentError(pointer: PaymentError_invoice(Bindings.new_LDKStr(string: a, chars_is_owned: true)));
     }
 
     public class func routing(a: LightningError) -> PaymentError {

bindings/LDK/results/Result_StringErrorZ.swift

@@ -54,7 +54,7 @@ public class Result_StringErrorZ: NativeTypeWrapper {
 
     public class func ok(o: String) -> Result_StringErrorZ {
 
-        return Result_StringErrorZ(pointer: CResult_StringErrorZ_ok(Bindings.new_LDKStr(string: o)));
+        return Result_StringErrorZ(pointer: CResult_StringErrorZ_ok(Bindings.new_LDKStr(string: o, chars_is_owned: true)));
     }
 
     #warning("This method passes non-cloneable objects by owned value. Here be dragons.")

bindings/LDK/structs/BackgroundProcessor.swift

@@ -13,7 +13,7 @@ public init(persister: Persister, event_handler: EventHandler, chain_monitor: Ch
     	Self.instanceCounter += 1
 		self.instanceNumber = Self.instanceCounter
 
-let graphMessageHandler = net_graph_msg_handler?.dangle().cOpaqueStruct! ?? LDKNetGraphMsgHandler(inner: nil, is_owned: true)
+let graphMessageHandler = net_graph_msg_handler?.cOpaqueStruct! ?? LDKNetGraphMsgHandler(inner: nil, is_owned: true)
 
         self.cOpaqueStruct = withUnsafePointer(to: chain_monitor.cOpaqueStruct!) { (chain_monitorPointer: UnsafePointer<LDKChainMonitor>) in
 withUnsafePointer(to: channel_manager.cOpaqueStruct!) { (channel_managerPointer: UnsafePointer<LDKChannelManager>) in

bindings/LDK/structs/Description.swift

@@ -58,7 +58,7 @@ Description_eq(aPointer, bPointer)
 
     public class func new(description: String) -> Result_DescriptionCreationErrorZ {
 
-        return Result_DescriptionCreationErrorZ(pointer: Description_new(Bindings.new_LDKStr(string: description)));
+        return Result_DescriptionCreationErrorZ(pointer: Description_new(Bindings.new_LDKStr(string: description, chars_is_owned: true)));
     }
 
     public func into_inner() -> String {

bindings/LDK/structs/ErrorMessage.swift

@@ -11,7 +11,7 @@ public class ErrorMessage: NativeTypeWrapper {
     	Self.instanceCounter += 1
 		self.instanceNumber = Self.instanceCounter
 
-        self.cOpaqueStruct = ErrorMessage_new(Bindings.new_LDKThirtyTwoBytes(array: channel_id_arg), Bindings.new_LDKStr(string: data_arg))
+        self.cOpaqueStruct = ErrorMessage_new(Bindings.new_LDKThirtyTwoBytes(array: channel_id_arg), Bindings.new_LDKStr(string: data_arg, chars_is_owned: true))
         super.init(conflictAvoidingVariableName: 0)
 
     }
@@ -62,7 +62,7 @@ ErrorMessage_get_data(this_ptrPointer)
 							let this_ptrPointer = UnsafeMutablePointer<LDKErrorMessage>.allocate(capacity: 1)
 							this_ptrPointer.initialize(to: self.cOpaqueStruct!)
 
-        return ErrorMessage_set_data(this_ptrPointer, Bindings.new_LDKStr(string: val));
+        return ErrorMessage_set_data(this_ptrPointer, Bindings.new_LDKStr(string: val, chars_is_owned: true));
     }
 
     public func clone() -> ErrorMessage {

bindings/LDK/structs/FilesystemPersister.swift

@@ -11,7 +11,7 @@ public class FilesystemPersister: NativeTypeWrapper {
     	Self.instanceCounter += 1
 		self.instanceNumber = Self.instanceCounter
 
-        self.cOpaqueStruct = FilesystemPersister_new(Bindings.new_LDKStr(string: path_to_channel_data))
+        self.cOpaqueStruct = FilesystemPersister_new(Bindings.new_LDKStr(string: path_to_channel_data, chars_is_owned: true))
         super.init(conflictAvoidingVariableName: 0)
 
     }
@@ -45,14 +45,14 @@ FilesystemPersister_get_data_dir(this_argPointer)
     public class func persist_manager(data_dir: String, manager: ChannelManager) -> Result_NoneErrorZ {
 
         return Result_NoneErrorZ(pointer: withUnsafePointer(to: manager.cOpaqueStruct!) { (managerPointer: UnsafePointer<LDKChannelManager>) in
-FilesystemPersister_persist_manager(Bindings.new_LDKStr(string: data_dir), managerPointer)
+FilesystemPersister_persist_manager(Bindings.new_LDKStr(string: data_dir, chars_is_owned: true), managerPointer)
 });
     }
 
     public class func persist_network_graph(data_dir: String, network_graph: NetworkGraph) -> Result_NoneErrorZ {
 
         return Result_NoneErrorZ(pointer: withUnsafePointer(to: network_graph.cOpaqueStruct!) { (network_graphPointer: UnsafePointer<LDKNetworkGraph>) in
-FilesystemPersister_persist_network_graph(Bindings.new_LDKStr(string: data_dir), network_graphPointer)
+FilesystemPersister_persist_network_graph(Bindings.new_LDKStr(string: data_dir, chars_is_owned: true), network_graphPointer)
 });
     }