Merge remote-tracking branch '39844/cleanup-remove-duplicated-values-in-array' into sept-comprs

Author: engcom-Charlie

app/code/Magento/OfflineShipping/Model/ResourceModel/Carrier/Tablerate/CSV/ColumnResolver.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2016 Adobe
+ * All Rights Reserved.
  */
 
 namespace Magento\OfflineShipping\Model\ResourceModel\Carrier\Tablerate\CSV;
@@ -22,7 +22,6 @@ class ColumnResolver
         self::COLUMN_COUNTRY => 0,
         self::COLUMN_REGION => 1,
         self::COLUMN_ZIP => 2,
-        self::COLUMN_WEIGHT => 3, // @phpstan-ignore-line
         self::COLUMN_WEIGHT_DESTINATION => 3,
         self::COLUMN_PRICE => 4,
     ];

app/code/Magento/OfflineShipping/Test/Unit/Model/ResourceModel/Carrier/Tablerate/CSV/ColumnResolverTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2016 Adobe
+ * All Rights Reserved.
  */
 declare(strict_types=1);
 
@@ -16,14 +16,15 @@
  */
 class ColumnResolverTest extends TestCase
 {
-    const CUSTOM_FIELD = 'custom_field';
+    private const CUSTOM_FIELD = 'custom_field';
 
-    // phpstan:ignore
+    /**
+     * @var array<string, string>
+     */
     private static $values = [
         ColumnResolver::COLUMN_COUNTRY => 'country value',
         ColumnResolver::COLUMN_REGION => 'region value',
         ColumnResolver::COLUMN_ZIP => 'zip_value',
-        ColumnResolver::COLUMN_WEIGHT => 'weight_value',
         ColumnResolver::COLUMN_WEIGHT_DESTINATION => 'weight_destination_value',
         ColumnResolver::COLUMN_PRICE => 'price_value',
         self::CUSTOM_FIELD => 'custom_value',
@@ -87,11 +88,6 @@ public static function getColumnValueDataProvider()
                 ColumnResolver::COLUMN_ZIP,
                 self::$values[ColumnResolver::COLUMN_ZIP],
             ],
-            // phpstan:ignore
-            ColumnResolver::COLUMN_WEIGHT => [
-                ColumnResolver::COLUMN_WEIGHT,
-                self::$values[ColumnResolver::COLUMN_WEIGHT],
-            ],
             ColumnResolver::COLUMN_WEIGHT_DESTINATION => [
                 ColumnResolver::COLUMN_WEIGHT_DESTINATION,
                 self::$values[ColumnResolver::COLUMN_WEIGHT_DESTINATION],