Skip to content

Conversation

@sandorstormen
Copy link
Contributor

@sandorstormen sandorstormen commented Nov 10, 2025

Changes performed_nodes to immutable ordered sequence.

@kasanari
Copy link
Collaborator

Would adding temporal info (e.g. timestep or similar) to the compromised attack steps not be a more general solution, in case the order or temporal location of the events are of interest?

@sandorstormen
Copy link
Contributor Author

Would adding temporal info (e.g. timestep or similar) to the compromised attack steps not be a more general solution, in case the order or temporal location of the events are of interest?

Sure, but this is just a quick fix (because it would be nice for me). We can work in absolute temporality later.

Copy link
Contributor

@mrkickling mrkickling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only problem I have is that the method node_is_compromised will go from finding a node in a set to finding a node in a tuple which means much worse performance. That function is not used internally so it doesn't affect performance in the simulator, but it could be used every step by some of the wrappers/interfaces.

@mrkickling mrkickling self-requested a review November 10, 2025 09:14
@mrkickling
Copy link
Contributor

Closing as we chose a different approach #240

@mrkickling mrkickling closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants