-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add software lists for the Ensoniq VFX-SD, SD-1 and SD-1/32 keyboards. #14498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b588ace to
a384964
Compare
hash/sd132_flop.xml
Outdated
| --> | ||
| <softwarelist name="sd132_flop" description="Ensoniq SD-1 32 Voice Disk Images"> | ||
|
|
||
| <software name="os400"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add supported="yes" or "no" to the <software> tag for each item to indicate if it's known working or not. I completely forgot this for the original version of the MPC3000 list recently and it caused a minor issue with the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Though, the documentation claims that
supported (optional)
One of the valuesyes(fully usable in emulation),no(not usable in emulation), orpartial(usable in emulation with limitations). If the attribute is not present, it is equivalent toyes.
Is that not accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
softwarelist.dtd seems to corroborate this:
<!ATTLIST software supported (yes|partial|no) "yes">
| @@ -0,0 +1,21 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm undecided on if it makes sense here, but you can have a single software list for a family of machines and use the <sharedfeat name="compatibility"> tag, something like this:
<sharedfeat name="compatibility" value="vfxsd,sd1,sd132" />
Then in the driver on the SOFTWARE_LIST() config item you'd append
.set_filter("sd1"); to mark a machine as able to use items with the sd1 tag.
I use that feature extensively for the mac_cdrom.xml list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that in some other software lists. But the nice thing about having multiple software lists is that, when choosing an item from a software list in the File Manager, the user first has to choose the software list from which to choose a floppy image:
This choice of software list seems to always happen, even if there's only a single software list:
So keeping them in different lists lets the user see that grouping, which I think is useful.
Each can also use the floppy disks for its predecessor, mainly because there are demo songs on the earlier OS disks that are not on the later ones, but which still work perfectly well and sounds great. The SD-1/32 software list also includes four demo disks: 1. A demo disk specifically for the SD-1/32 2. A demo disk for the SQ-series of keyboards with 32 voices This contains System Exclusive files foro use with 32-voice SQ series keyboards 3. Two multi-product demo disks These contain both sequencer files for the SD-1/32 and System Exclusive files for use with the SQ and KS series of keyboards.
|
Thank you! |
This PR builds on the floppy disk functionality improvements in #14444 and adds the Sequencer OS floppy images for each major version, as well as some demo disks.
Each can also use the floppy disks for its predecessor, mainly because
there are demo songs on the earlier OS disks that are not on the later ones,
but which still work perfectly well and sounds great.
The SD-1/32 software list also includes four demo disks:
A demo disk specifically for the SD-1/32
A demo disk for the SQ-series of keyboards with 32 voices
This contains System Exclusive files foro use with 32-voice SQ series
keyboards
Two multi-product demo disks
These contain both sequencer files for the SD-1/32 and System
Exclusive files for use with the SQ and KS series of keyboards.