LR1110 IRQ fixes #1018
Merged
LR1110 IRQ fixes #1018
+2
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix incorrect irqs used in isReceiving. also remove getTimeOnAir override as fixed upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isReceiving function (used for delaying TX until clear) was using incorrect IRQs meaning instead of checking the HEADER_VALID IRQ, TX_DONE was used instead. This PR removes the incorrect defines and uses the correct RadioLib defines instead. I also removed the getTimeOnAir override as this appears to have been fixed upstream as part of jgromes/RadioLib#1596.