Skip to content

Commit 28cefeb

Browse files
committed
Fix CI dependency resolution tests to actually test target versions
The dependency resolution tests were using --frozen flag (for highest) or no upgrade flag (for lowest-direct), which meant both tests just used whatever was locked in uv.lock from the main branch rather than actually resolving to the target versions. This caused the CI to miss breaking changes in new dependency versions (like pydantic 2.12) that were compatible with version constraints but not yet in the lockfile. Changes: - Use --upgrade --resolution highest for the highest resolution test - Use --upgrade --resolution lowest-direct for the lowest resolution test (both need --upgrade to ignore lockfile and re-resolve) - Simplify test execution to use --frozen --no-sync since resolution already happened during uv sync - Remove redundant UV_RESOLUTION env var (command-line flags suffice) This ensures both tests actually resolve to their intended versions and catch compatibility issues before they reach main.
1 parent da4fce2 commit 28cefeb

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

.github/workflows/shared.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ jobs:
3838
python-version: ["3.10", "3.11", "3.12", "3.13"]
3939
dep-resolution:
4040
- name: lowest-direct
41-
install-flags: "--resolution lowest-direct"
41+
install-flags: "--upgrade --resolution lowest-direct"
4242
- name: highest
43-
install-flags: "--frozen"
43+
install-flags: "--upgrade --resolution highest"
4444
os: [ubuntu-latest, windows-latest]
4545

4646
steps:
@@ -56,9 +56,7 @@ jobs:
5656
run: uv sync ${{ matrix.dep-resolution.install-flags }} --all-extras --python ${{ matrix.python-version }}
5757

5858
- name: Run pytest
59-
run: uv run ${{ matrix.dep-resolution.install-flags }} --no-sync pytest
60-
env:
61-
UV_RESOLUTION: ${{ matrix.dep-resolution.name == 'lowest-direct' && 'lowest-direct' || 'highest' }}
59+
run: uv run --frozen --no-sync pytest
6260

6361
readme-snippets:
6462
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)