Skip to content

Commit ad108cd

Browse files
committed
Fix CI highest resolution test to actually test highest versions
The "highest" dependency resolution test was using --frozen flag, which prevented uv from updating dependencies to their highest available versions. This meant the test was using whatever was locked in uv.lock from the main branch, not the actual highest versions. This caused the CI to miss breaking changes in new dependency versions (like pydantic 2.12) that were compatible with version constraints but not yet in the lockfile. Changes: - Use --upgrade --resolution highest for the highest resolution test (--upgrade is needed to ignore the lockfile and re-resolve) - Use --resolution lowest-direct for the lowest resolution test - Simplify test execution to use --frozen --no-sync since resolution already happened during uv sync - Remove redundant UV_RESOLUTION env var (command-line flags suffice) This ensures the highest test catches compatibility issues with newer dependency versions before they reach main.
1 parent da4fce2 commit ad108cd

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

.github/workflows/shared.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
- name: lowest-direct
4141
install-flags: "--resolution lowest-direct"
4242
- name: highest
43-
install-flags: "--frozen"
43+
install-flags: "--upgrade --resolution highest"
4444
os: [ubuntu-latest, windows-latest]
4545

4646
steps:
@@ -56,9 +56,7 @@ jobs:
5656
run: uv sync ${{ matrix.dep-resolution.install-flags }} --all-extras --python ${{ matrix.python-version }}
5757

5858
- name: Run pytest
59-
run: uv run ${{ matrix.dep-resolution.install-flags }} --no-sync pytest
60-
env:
61-
UV_RESOLUTION: ${{ matrix.dep-resolution.name == 'lowest-direct' && 'lowest-direct' || 'highest' }}
59+
run: uv run --frozen --no-sync pytest
6260

6361
readme-snippets:
6462
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)