Fix CI highest resolution test to actually test highest versions #1609
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxisbey
force-pushed
the
fix-ci-highest-resolution-testing
branch
from
4504ab8 to
ad108cd
Compare
The dependency resolution tests were using --frozen flag (for highest) or no upgrade flag (for lowest-direct), which meant both tests just used whatever was locked in uv.lock from the main branch rather than actually resolving to the target versions. This caused the CI to miss breaking changes in new dependency versions (like pydantic 2.12) that were compatible with version constraints but not yet in the lockfile. Changes: - Use --upgrade --resolution highest for the highest resolution test - Use --upgrade --resolution lowest-direct for the lowest resolution test (both need --upgrade to ignore lockfile and re-resolve) - Simplify test execution to use --frozen --no-sync since resolution already happened during uv sync - Remove redundant UV_RESOLUTION env var (command-line flags suffice) This ensures both tests actually resolve to their intended versions and catch compatibility issues before they reach main.
maxisbey
force-pushed
the
fix-ci-highest-resolution-testing
branch
from
ad108cd to
28cefeb
Compare
Contributor
Author
|
The tests are currently failing, which is intended. This PR will fix the tests: #1607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI dependency resolution testing to properly test against the highest available dependency versions, which would have caught the pydantic 2.12 breaking change before it reached main.
Motivation and Context
The CI test matrix includes a "highest" resolution test intended to catch compatibility issues with newer dependency versions. However, it was using the
--frozenflag, which prevented uv from resolving to the highest available versions. Instead, it just used whatever was locked inuv.lockfrom main, defeating the purpose of testing against latest versions.This meant breaking changes in newer dependency versions (like pydantic 2.12's
FieldInforefactor) that were compatible with our version constraints but not yet in the lockfile would not be caught by CI.How Has This Been Tested?
The changes are to CI configuration only. The fix:
--resolution highestduringuv syncfor the highest resolution test--resolution lowest-directfor the lowest resolution test (unchanged behavior)uv runto use--frozen --no-syncsince resolution already happened during syncUV_RESOLUTIONenvironment variableThis ensures the highest test matrix actually resolves to and tests against the highest available versions within our constraints.
Breaking Changes
None. This is a CI configuration improvement that makes the tests work as originally intended.
Types of changes
Checklist
Additional context
This fix is related to the pydantic 2.12 compatibility issue discovered in the investigation. With this change, future dependency updates that introduce breaking changes will be caught by the "highest" resolution CI tests before merging to main.
The fix clarifies the intent of each step:
uv syncwith resolution flags → resolve and install dependenciesuv run --frozen→ run tests with what was synced (no re-resolution)