Skip to content

fix(metro-core): workflow build of metro plugins #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: workflow/metro-yaml
Choose a base branch
from
+12 −4
Draft

fix(metro-core): workflow build of metro plugins #4147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/actions/android-e2e/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ runs:
run: pnpm install --frozen-lockfile
shell: bash

- name: Build Metro packages
run: npx nx run-many --targets=build --projects=tag:type:metro --parallel=4
shell: bash

- name: Install Maestro CLI
run: |
curl -Ls "https://get.maestro.mobile.dev" | bash
Expand Down
4 changes: 4 additions & 0 deletions .github/actions/ios-e2e/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ runs:
run: pnpm install --frozen-lockfile
shell: bash

- name: Build Metro packages
run: npx nx run-many --targets=build --projects=tag:type:metro --parallel=4
shell: bash

- name: Install Maestro CLI and iOS Utilities
run: |
curl -Ls "https://get.maestro.mobile.dev" | bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
secrets: inherit

e2e-metro:
needs: [checkout-install, build-metro]
needs: checkout-install
uses: ./.github/workflows/e2e-metro.yml
secrets: inherit

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-metro.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
app_name: [example-host]
app_name: [metro-example-host]
env:
ANDROID_EMULATOR_API_LEVEL: 28
ANDROID_EMULATOR_TARGET: default
Expand All @@ -36,7 +36,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
app_name: [example-host]
app_name: [metro-example-host]
env:
RUBY_VERSION: 2.7.6
MAESTRO_VERSION: 1.39.13
Expand Down
2 changes: 1 addition & 1 deletion apps/metro-example-host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "example-host",
"name": "metro-example-host",
"version": "0.0.1",
"private": true,
"scripts": {
Expand Down
Loading