This repository was archived by the owner on Feb 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
WIP Vendoring documentation #5217
Open
dmose
wants to merge
5
commits into
mozilla:master
Choose a base branch
from
dmose:vendor-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Vendoring in npm libraries | ||
|
|
||
| #### Build system basics | ||
|
|
||
| #### Vendored libraries as externals | ||
|
|
||
| #### Is this library a good candidate to depend on and vendor? | ||
|
|
||
| #### How to vendor in a library | ||
|
|
||
| - [ ] file a bug for vendoring in the library itself so that there's | ||
| an easy-to-find audit trail in Bugzilla, should it be needed | ||
|
|
||
| - [ ] Get license approval from the licensing team | ||
|
|
||
| - [ ] review the mozilla-central policy at | ||
| https://www.mozilla.org/en-US/MPL/license-policy/ | ||
| - [ ] file a license bug as described in the policy doc to request approval | ||
dmose marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - [ ] make it block the next upcoming export bug (if that bug is not already | ||
| filed, file one) | ||
| - [ ] post a patch to add the license to | ||
| [ `toolkit/content/license.html` ](https://searchfox.org/mozilla-central/source/toolkit/content/license.html) | ||
| - [ ] get the patch reviewed | ||
| - [ ] make sure that the patch gets landed at export time. | ||
|
|
||
| - [ ] Install the package using npm | ||
|
|
||
| - [ ] Check that you're using npm 6.9.0 with `npm --version` | ||
| - [ ] Be sure to save the exact version by passing `--save-exact` to | ||
| `npm install` | ||
|
|
||
| - [ ] Include the vendored files and reference them | ||
|
|
||
| - [ ] update [`bin/vendor.js`](../../bin/vendor.js) to copy any files | ||
| needed at runtime as well as the license to the [`vendor/` | ||
| directory](../../vendor/) | ||
| - [ ] execute `bin/vendor.js` to copy your files into place so they get | ||
| committed and referenced at runtime | ||
| - [ ] add the exported symbol (the library's global name) for your library | ||
| to the list of externals in | ||
| [`webpack.system-addon.config.js`](../../webpack.system-addon.config.js) | ||
| so that webpack knows where to link the symbol from | ||
| - [ ] add the library to the list of scripts in | ||
| [`bin/render-activity-stream-html.js`](../../bin/render-activity-stream-html.js) | ||
| so it gets loaded at runtime | ||
| - [ ] add the library to the list of scripts in | ||
| [`AboutNewTabService.jsm`](../../AboutNewTabService.jsm) so that it gets | ||
| preloaded for better browser startup performance | ||
| - [ ] add the library to [`jar.mn`](../../jar.mn) so that it gets | ||
| packaged into released builds | ||
| - [ ] test and make sure that everything builds and works at runtime | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.