trimming the output #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozillazg
requested changes
Apr 5, 2023
Owner
mozillazg
left a comment
mozillazg
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I added some comments.
| textSlice := flag.Args() | ||
| stdin := []byte{} | ||
| if !isatty.IsTerminal(os.Stdin.Fd()) { | ||
| if !isTerminal(os.Stdin.Fd()) { |
Owner
There was a problem hiding this comment.
we need github.com/mattn/go-isatty to support mac os and windows.
| // e.g. Unidecode("kožušček") => "kozuscek" | ||
| func Unidecode(s string) string { | ||
| return unidecode(s) | ||
| return strings.Trim(unidecode(s), " ") |
Owner
There was a problem hiding this comment.
What happens when the s is kožušček ? Does it return an unexpected kozuscek?
IMHO, letting the caller do the trim work is more simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #8
Benchmark suffers by about 12% iterations on my machine.