OAuth2 - PKCE | CI

Jesse Doyle · Jesse Doyle · commit 13dde0ca2183 · 2020-08-10T13:44:03.000-06:00
__review__

* Remove Ruby 2.3 frozen string magic comments as requested because
  it is out of scope for this feature.
* Add an exception to `rubocop.yml` so that the missing
  magic comment is not a CI failure.
* Add exceptions for `Lint/MissingSuper` and
  `Gemspec/REquiredRubyVersion` to minimize churn on the feature.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,6 +1,9 @@
 AllCops:
   NewCops: enable
 
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
 Layout/AccessModifierIndentation:
   EnforcedStyle: outdent
 
@@ -11,8 +14,11 @@ Layout/LineLength:
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
+Lint/MissingSuper:
+  Enabled: false
+
 Metrics/AbcSize:
-  Max: 17
+  Max: 18
 
 Metrics/BlockLength:
   Exclude:
@@ -52,6 +58,9 @@ Style/DoubleNegation:
 Style/ExpandPathArguments:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 
diff --git a/Gemfile b/Gemfile
@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 source "https://rubygems.org"
 
 gem "rake", "~> 12.0"
diff --git a/Rakefile b/Rakefile
@@ -1,5 +1,4 @@
 #!/usr/bin/env rake
-# frozen_string_literal: true
 
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
diff --git a/lib/omniauth-oauth2.rb b/lib/omniauth-oauth2.rb
@@ -1,4 +1,2 @@
-# frozen_string_literal: true
-
 require "omniauth-oauth2/version"
 require "omniauth/strategies/oauth2"
diff --git a/lib/omniauth-oauth2/version.rb b/lib/omniauth-oauth2/version.rb
@@ -1,7 +1,5 @@
-# frozen_string_literal: true
-
 module OmniAuth
   module OAuth2
-    VERSION = "1.6.0"
+    VERSION = "1.6.0".freeze
   end
 end
diff --git a/lib/omniauth/strategies/oauth2.rb b/lib/omniauth/strategies/oauth2.rb
@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require "oauth2"
 require "omniauth"
 require "securerandom"
diff --git a/omniauth-oauth2.gemspec b/omniauth-oauth2.gemspec
@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "omniauth-oauth2/version"
diff --git a/spec/helper.rb b/spec/helper.rb
@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 $LOAD_PATH.unshift File.expand_path("..", __FILE__)
 $LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
 
diff --git a/spec/omniauth/strategies/oauth2_spec.rb b/spec/omniauth/strategies/oauth2_spec.rb
@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require "helper"
 
 describe OmniAuth::Strategies::OAuth2 do

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# frozen_string_literal: true`
`2`		`-`
`3`	`1`	`source "https://rubygems.org"`
`4`	`2`
`5`	`3`	`gem "rake", "~> 12.0"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`#!/usr/bin/env rake`
`2`		`-# frozen_string_literal: true`
`3`	`2`
`4`	`3`	`require "bundler/gem_tasks"`
`5`	`4`	`require "rspec/core/rake_task"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# frozen_string_literal: true`
`2`		`-`
`3`	`1`	`require "oauth2"`
`4`	`2`	`require "omniauth"`
`5`	`3`	`require "securerandom"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# frozen_string_literal: true`
`2`		`-`
`3`	`1`	`lib = File.expand_path("../lib", __FILE__)`
`4`	`2`	`$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)`
`5`	`3`	`require "omniauth-oauth2/version"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# frozen_string_literal: true`
`2`		`-`
`3`	`1`	`$LOAD_PATH.unshift File.expand_path("..", __FILE__)`
`4`	`2`	`$LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)`
`5`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# frozen_string_literal: true`
`2`		`-`
`3`	`1`	`require "helper"`
`4`	`2`
`5`	`3`	`describe OmniAuth::Strategies::OAuth2 do`