SCP: Add a -F option to SET <dev> DISABLE command to force detach and cancel #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello @markpizz Instead of requiring -F, why not disable the timers unconditionally if the device does not have any attached units? Thanks, |
Contributor
Author
Patrick had units doing timing activity. Units could be doing anything. In any case, the point here is that a functional change to how a command behaves conceptually requires different input. For whatever reason, someone might want the prior behavior, so it remains as the default. The -F forces disabling of devices with attached units or units in the event queue. |
deltecent
added a commit
to deltecent/open-simh
that referenced
this pull request
Sep 2, 2025
This PR contains the following: Adds a new SD Systems SBC200 device. Adds a new SD Systems VFII VersaFloppy II device. Adds ability to load HEX files at a specified address. Adds support for SD Systems ExpandoRAM banked memory. Adds improved DSK image support to the WD179X device. Adds support for formats that don't include the FC index mark to WD179X WRITE_TRACK command. Fixed WD179X VERIFY register. Updated CMakeList.txt Included PR open-simh#492 in scp.c Replaced binary notation with hex notation in s100_scb200.c This PR passes Howard's AltairZ80 tests. Additional tests were added here: https://github.com/deltecent/altairz80-tests/ Additional packages were added here: https://github.com/deltecent/altairz80-packages/
deltecent
added a commit
to deltecent/open-simh
that referenced
this pull request
Sep 3, 2025
This PR contains the following: Adds a new SD Systems SBC200 device. Adds a new SD Systems VFII VersaFloppy II device. Adds ability to load HEX files at a specified address. Adds support for SD Systems ExpandoRAM banked memory. Adds improved DSK image support to the WD179X device. Adds support for formats that don't include the FC index mark to WD179X WRITE_TRACK command. Fixed WD179X VERIFY register. Updated CMakeList.txt Included PR open-simh#492 in scp.c Replaced binary notation with hex notation in s100_scb200.c Fixed Warnings This PR passes Howard's AltairZ80 tests. Additional tests were added here: https://github.com/deltecent/altairz80-tests/ Additional packages were added here: https://github.com/deltecent/altairz80-packages/
deltecent
added a commit
to deltecent/open-simh
that referenced
this pull request
Sep 6, 2025
This PR contains the following: Adds a new SD Systems SBC200 device. Adds a new SD Systems VFII VersaFloppy II device. Adds ability to load HEX files at a specified address. Adds support for SD Systems ExpandoRAM banked memory. Adds improved DSK image support to the WD179X device. Adds support for formats that don't include the FC index mark to WD179X WRITE_TRACK command. Fixed WD179X VERIFY register. Updated CMakeList.txt Included PR open-simh#492 in scp.c Replaced binary notation with hex notation in s100_scb200.c Fixed Warnings Fixed DTR comments This PR passes Howard's AltairZ80 tests. Additional tests were added here: https://github.com/deltecent/altairz80-tests/ Additional packages were added here: https://github.com/deltecent/altairz80-packages/
markpizz
force-pushed
the
extend_scp_device_disable
branch
from
2fcf526 to
1071f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically some devices may not have been able to be DISABLED once they've been ENABLED.
This change allows such a device to be disabled when SET {-F} DISABLE command is invoked with the -F flag specified.