Skip to content

Conversation

@nickbianco
Copy link
Member

@nickbianco nickbianco commented Nov 6, 2025

Fixes issue #4184

Brief summary of changes

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...changes to CI suite.

This change is Reviewable

@nickbianco nickbianco marked this pull request as ready for review November 6, 2025 21:13
@nickbianco nickbianco force-pushed the ci_job_updates_and_cleanup branch from a32ed49 to 8d57714 Compare November 6, 2025 21:18
@nickbianco nickbianco changed the title Add Ubuntu 24.04, Windows 2025 CI jobs and clean up stale files [WIP] Add Ubuntu 24.04, Windows 2025 CI jobs and clean up stale files Nov 7, 2025
@nickbianco
Copy link
Member Author

@adamkewley FYI I'm working towards officially supporting Ubuntu 24 (and Windows 2025, while I'm at it) in the CI. I've updated Bindings/SWIGSimTK/Mat.h and Bindings/SWIGSimTK/Vec.h based on the recent changes in Simbody. However, because of the recent changes, I had to temporarily remove a handful of SWIG commands to get the bindings to build locally. I plan to add them back in one-by-one and sort out the issues as I go.

@nickbianco nickbianco changed the title [WIP] Add Ubuntu 24.04, Windows 2025 CI jobs and clean up stale files [WIP] Add Ubuntu 24.04 and Windows 2025 CI jobs Nov 7, 2025
@aymanhab
Copy link
Member

aymanhab commented Nov 7, 2025

Not sure if upgrading to swig 4.4 can help, worth trying. If we can upgrade swig instead of changing code that's likely less error prone, eventually we maybe able to retire the swigsimtk hack and use the headers from simbody as is. Wishful thinking...

@nickbianco
Copy link
Member Author

retire the swigsimtk hack and use the headers from simbody as is

Why is this hack needed again?

@aymanhab
Copy link
Member

aymanhab commented Nov 7, 2025

retire the swigsimtk hack and use the headers from simbody as is

Why is this hack needed again?

Because swig can't digest simbody headers and templates as is.

@nickbianco nickbianco force-pushed the ci_job_updates_and_cleanup branch 2 times, most recently from a9e238c to 93460ce Compare November 14, 2025 17:02
@nickbianco nickbianco force-pushed the ci_job_updates_and_cleanup branch from 93460ce to c5acdbd Compare November 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants