Skip to content

Commit d628732

Browse files
refactor: optimize log level conversion
- Remove unnecessary default log level value initialization - Refactor switch statement to directly return log levels for each case - Simplify comparison for warning log levels to include both "WARN" and "WARNING"
1 parent 6620481 commit d628732

File tree

1 file changed

+13
-21
lines changed

1 file changed

+13
-21
lines changed

android/src/main/java/com/optimizely/optimizely_flutter_sdk/FlutterLogbackAppender.java

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ protected void append(ILoggingEvent event) {
2929

3030
String message = event.getFormattedMessage();
3131
String level = event.getLevel().toString();
32-
// print level here
33-
System.out.println("loglevel: " + level);
3432
int logLevel = convertLogLevel(level);
3533
Map<String, Object> logData = new HashMap<>();
3634
logData.put("level", logLevel);
@@ -44,28 +42,22 @@ protected void append(ILoggingEvent event) {
4442
}
4543

4644
int convertLogLevel(String logLevel) {
47-
int level = 3; // Default to INFO
48-
4945
if (logLevel == null || logLevel.isEmpty()) {
50-
return level;
46+
return 3;
5147
}
5248

53-
switch (logLevel.toLowerCase()) {
54-
case Constants.LogLevel.ERROR:
55-
level = 1;
56-
break;
57-
case Constants.LogLevel.WARNING:
58-
level = 2;
59-
break;
60-
case Constants.LogLevel.INFO:
61-
level = 3;
62-
break;
63-
case Constants.LogLevel.DEBUG:
64-
level = 4;
65-
break;
66-
default: {
67-
}
49+
switch (logLevel.toUpperCase()) {
50+
case "ERROR":
51+
return 1;
52+
case "WARN":
53+
case "WARNING":
54+
return 2;
55+
case "INFO":
56+
return 3;
57+
case "DEBUG":
58+
return 4;
59+
default:
60+
return 3;
6861
}
69-
return level;
7062
}
7163
}

0 commit comments

Comments
 (0)