Fix lint issues

Author: esrakartalOpt

optimizely/project_config.py

@@ -98,15 +98,15 @@ def __init__(self, datafile: str | bytes, logger: Logger, error_handler: Any):
         for holdout in self.holdouts:
             if holdout.get('status') != 'Running':
                 continue
-            
+
             holdout_id = holdout['id']
             self.holdout_id_map[holdout_id] = holdout
-            
+
             included_flags = holdout.get('includedFlags')
             if not included_flags:
                 # This is a global holdout
                 self.global_holdouts[holdout_id] = holdout
-                
+
                 excluded_flags = holdout.get('excludedFlags')
                 if excluded_flags:
                     for flag_id in excluded_flags:

tests/test_config.py

@@ -1380,15 +1380,14 @@ def test_get_variation_from_key_by_experiment_id_missing(self):
 class HoldoutConfigTest(base.BaseTest):
     def setUp(self):
         base.BaseTest.setUp(self)
-        
+
         # Create config with holdouts
         config_body_with_holdouts = self.config_dict_with_features.copy()
-        
+
         # Use correct feature flag IDs from the datafile
         boolean_feature_id = '91111'  # boolean_single_variable_feature
         multi_variate_feature_id = '91114'  # test_feature_in_experiment_and_rollout
-        string_feature_id = '91112'  # test_feature_in_rollout
-        
+
         config_body_with_holdouts['holdouts'] = [
             {
                 'id': 'holdout_1',
@@ -1412,63 +1411,63 @@ def setUp(self):
                 'excludedFlags': []
             }
         ]
-        
+
         self.config_json_with_holdouts = json.dumps(config_body_with_holdouts)
         opt_obj = optimizely.Optimizely(self.config_json_with_holdouts)
         self.config_with_holdouts = opt_obj.config_manager.get_config()
 
     def test_get_holdouts_for_flag__non_existent_flag(self):
         """ Test that get_holdouts_for_flag returns empty array for non-existent flag. """
-        
+
         holdouts = self.config_with_holdouts.get_holdouts_for_flag('non_existent_flag')
         self.assertEqual([], holdouts)
 
     def test_get_holdouts_for_flag__returns_global_and_specific_holdouts(self):
         """ Test that get_holdouts_for_flag returns global holdouts that do not exclude the flag
         and specific holdouts that include the flag. """
-        
+
         holdouts = self.config_with_holdouts.get_holdouts_for_flag('test_feature_in_experiment_and_rollout')
         self.assertEqual(2, len(holdouts))
-        
+
         global_holdout = next((h for h in holdouts if h['key'] == 'global_holdout'), None)
         self.assertIsNotNone(global_holdout)
         self.assertEqual('holdout_1', global_holdout['id'])
-        
+
         specific_holdout = next((h for h in holdouts if h['key'] == 'specific_holdout'), None)
         self.assertIsNotNone(specific_holdout)
         self.assertEqual('holdout_2', specific_holdout['id'])
 
     def test_get_holdouts_for_flag__excludes_global_holdouts_for_excluded_flags(self):
         """ Test that get_holdouts_for_flag does not return global holdouts that exclude the flag. """
-        
+
         holdouts = self.config_with_holdouts.get_holdouts_for_flag('boolean_single_variable_feature')
         self.assertEqual(0, len(holdouts))
-        
+
         global_holdout = next((h for h in holdouts if h['key'] == 'global_holdout'), None)
         self.assertIsNone(global_holdout)
 
     def test_get_holdouts_for_flag__caches_results(self):
         """ Test that get_holdouts_for_flag caches results for subsequent calls. """
-        
+
         holdouts1 = self.config_with_holdouts.get_holdouts_for_flag('test_feature_in_experiment_and_rollout')
         holdouts2 = self.config_with_holdouts.get_holdouts_for_flag('test_feature_in_experiment_and_rollout')
-        
+
         # Should be the same object (cached)
         self.assertIs(holdouts1, holdouts2)
         self.assertEqual(2, len(holdouts1))
 
     def test_get_holdouts_for_flag__returns_only_global_for_non_targeted_flags(self):
         """ Test that get_holdouts_for_flag returns only global holdouts for flags not specifically targeted. """
-        
+
         holdouts = self.config_with_holdouts.get_holdouts_for_flag('test_feature_in_rollout')
-        
+
         # Should only include global holdout (not excluded and no specific targeting)
         self.assertEqual(1, len(holdouts))
         self.assertEqual('global_holdout', holdouts[0]['key'])
 
     def test_get_holdout__returns_holdout_for_valid_id(self):
         """ Test that get_holdout returns holdout when valid ID is provided. """
-        
+
         holdout = self.config_with_holdouts.get_holdout('holdout_1')
         self.assertIsNotNone(holdout)
         self.assertEqual('holdout_1', holdout['id'])
@@ -1477,7 +1476,7 @@ def test_get_holdout__returns_holdout_for_valid_id(self):
 
     def test_get_holdout__returns_holdout_regardless_of_status(self):
         """ Test that get_holdout returns holdout regardless of status when valid ID is provided. """
-        
+
         holdout = self.config_with_holdouts.get_holdout('holdout_2')
         self.assertIsNotNone(holdout)
         self.assertEqual('holdout_2', holdout['id'])
@@ -1486,52 +1485,52 @@ def test_get_holdout__returns_holdout_regardless_of_status(self):
 
     def test_get_holdout__returns_none_for_non_existent_id(self):
         """ Test that get_holdout returns None for non-existent holdout ID. """
-        
+
         holdout = self.config_with_holdouts.get_holdout('non_existent_holdout')
         self.assertIsNone(holdout)
 
     def test_get_holdout__logs_error_when_not_found(self):
         """ Test that get_holdout logs error when holdout is not found. """
-        
+
         with mock.patch.object(self.config_with_holdouts, 'logger') as mock_logger:
             result = self.config_with_holdouts.get_holdout('invalid_holdout_id')
-            
+
             self.assertIsNone(result)
             mock_logger.error.assert_called_once_with('Holdout with ID "invalid_holdout_id" not found.')
 
     def test_get_holdout__does_not_log_when_found(self):
         """ Test that get_holdout does not log when holdout is found. """
-        
+
         with mock.patch.object(self.config_with_holdouts, 'logger') as mock_logger:
             result = self.config_with_holdouts.get_holdout('holdout_1')
-            
+
             self.assertIsNotNone(result)
             mock_logger.error.assert_not_called()
 
     def test_holdout_initialization__categorizes_holdouts_properly(self):
         """ Test that holdouts are properly categorized during initialization. """
-        
+
         self.assertIn('holdout_1', self.config_with_holdouts.holdout_id_map)
         self.assertIn('holdout_2', self.config_with_holdouts.holdout_id_map)
         self.assertIn('holdout_1', self.config_with_holdouts.global_holdouts)
-        
+
         # Use correct feature flag IDs
         boolean_feature_id = '91111'
         multi_variate_feature_id = '91114'
-        
+
         self.assertIn(multi_variate_feature_id, self.config_with_holdouts.included_holdouts)
         self.assertTrue(len(self.config_with_holdouts.included_holdouts[multi_variate_feature_id]) > 0)
         self.assertNotIn(boolean_feature_id, self.config_with_holdouts.included_holdouts)
-        
+
         self.assertIn(boolean_feature_id, self.config_with_holdouts.excluded_holdouts)
         self.assertTrue(len(self.config_with_holdouts.excluded_holdouts[boolean_feature_id]) > 0)
 
     def test_holdout_initialization__only_processes_running_holdouts(self):
         """ Test that only running holdouts are processed during initialization. """
-        
+
         self.assertNotIn('holdout_3', self.config_with_holdouts.holdout_id_map)
         self.assertNotIn('holdout_3', self.config_with_holdouts.global_holdouts)
-        
+
         boolean_feature_id = '91111'
         included_for_boolean = self.config_with_holdouts.included_holdouts.get(boolean_feature_id)
         self.assertIsNone(included_for_boolean)