From 78540ff978c21ba774271d9d8f0289544b5c4fe6 Mon Sep 17 00:00:00 2001
From: intrand <intrand@users.noreply.github.com>
Date: Wed, 24 Sep 2025 12:16:28 -0500
Subject: [PATCH] add 'for:' field to cadvisor prometheus rule

---
 charts/perfectscale-agent/templates/prometheus-rule.yaml | 3 +++
 charts/perfectscale-agent/values.yaml                    | 1 +
 2 files changed, 4 insertions(+)

diff --git a/charts/perfectscale-agent/templates/prometheus-rule.yaml b/charts/perfectscale-agent/templates/prometheus-rule.yaml
index 98d4e5e..496eaa7 100644
--- a/charts/perfectscale-agent/templates/prometheus-rule.yaml
+++ b/charts/perfectscale-agent/templates/prometheus-rule.yaml
@@ -56,6 +56,9 @@ spec:
             summary: "{{ $fullName }} high cAdvisor scraping error rate"
           expr: |
             (increase(psc_exporter_cadvisor_scraping_errors_total[{{ .Values.prometheusRule.cAdvisorScraping.timeRange }}]) / avg_over_time(psc_exporter_cadvisor_instances_scraped[{{ .Values.prometheusRule.cAdvisorScraping.timeRange }}])) > {{ .Values.prometheusRule.cAdvisorScraping.threshold }}
+          {{- if .Values.prometheusRule.cAdvisorScraping.for }}
+          for: {{ .Values.prometheusRule.cAdvisorScraping.for }}
+          {{- end }}
           labels:
             {{- if .Values.prometheusRule.team }}
             team: {{ .Values.prometheusRule.team }}
diff --git a/charts/perfectscale-agent/values.yaml b/charts/perfectscale-agent/values.yaml
index 01da9b2..81d9842 100644
--- a/charts/perfectscale-agent/values.yaml
+++ b/charts/perfectscale-agent/values.yaml
@@ -164,6 +164,7 @@ prometheusRule:
   cAdvisorScraping:
     timeRange: "30m"
     threshold: 0.3
+    for: "30m"
   cpuUtilization:
     enable: false
     threshold: 8 # default value