Skip to content

Commit e36a7e3

Browse files
committed
chore: expand sharedGlobals pattern to include all YAML files in .github directory (#349)
### TL;DR Updated the `sharedGlobals` pattern in nx.json to include all YAML files in the .github directory. ### What changed? Modified the `sharedGlobals` configuration in nx.json to use a more inclusive pattern. Changed from specifically targeting only the CI workflow file (`{workspaceRoot}/.github/workflows/ci.yml`) to including all YAML files in the .github directory and its subdirectories (`{workspaceRoot}/.github/**/*.yml`). ### How to test? 1. Verify that Nx correctly recognizes changes to any YAML file in the .github directory 2. Make a change to a YAML file outside the workflows directory and confirm it's properly detected 3. Run `nx affected` commands to ensure they correctly identify projects affected by changes to GitHub YAML files ### Why make this change? This change ensures that modifications to any GitHub YAML configuration file (not just the CI workflow) are properly tracked by Nx's dependency graph. This provides better visibility into how GitHub configuration changes might affect projects in the workspace and ensures more accurate affected commands.
1 parent 2888ce0 commit e36a7e3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

nx.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"!{projectRoot}/tsconfig.spec.json",
1212
"!{projectRoot}/src/test-setup.[jt]s"
1313
],
14-
"sharedGlobals": ["{workspaceRoot}/.github/workflows/ci.yml"],
14+
"sharedGlobals": ["{workspaceRoot}/.github/**/*.yml"],
1515
"sqruffConfig": ["{workspaceRoot}/.sqruff"]
1616
},
1717
"nxCloudId": "676490227393fa777407053a",

0 commit comments

Comments
 (0)