Skip to content

feat: demo improve modal copy #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: demo improve modal copy #327

wants to merge 1 commit into from

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Nov 7, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b90bf4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Nov 7, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jumski Graphite App
Copy link
Contributor Author

jumski commented Nov 7, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge:queue - adds this PR to the back of the merge queue
  • hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 7, 2025
Closed
Closed
@nx-cloud
Copy link

nx-cloud bot commented Nov 7, 2025 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit b90bf4f

Command Status Duration Result
nx affected -t lint typecheck test --parallel -... ❌ Failed 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-11 14:44:43 UTC

@jumski jumski mentioned this pull request Nov 7, 2025
Closed
graphite-app[bot]
graphite-app bot reviewed Nov 7, 2025
View reviewed changes
apps/demo/src/lib/components/CodePanel.svelte
Comment on lines 5 to +8
import type { createFlowState } from '$lib/stores/pgflow-state-improved.svelte';
import StatusBadge from '$lib/components/StatusBadge.svelte';
import PulseDot from '$lib/components/PulseDot.svelte';
import MiniDAG from '$lib/components/MiniDAG.svelte';
Copy link
Contributor

@graphite-app graphite-app bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear to be unused imports in this file. Remove any imports that are not being used in the component such as 'Card', 'CardContent', 'CardHeader', 'CardTitle', 'hoveredStep' if they exist in the import list.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

apps/demo/src/lib/components/MiniDAG.svelte
Comment on lines +83 to +87
{#each edgePaths as edge}
{#if edge}
<path class="edge" d={edge.d} />
{/if}
{/each}
Copy link
Contributor

@graphite-app graphite-app bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This each block is missing a key attribute. Add a key using the edge id or index: {#each edgePaths as edge, i (edge?.id || i)}

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

apps/demo/src/lib/components/MiniDAG.svelte
Comment on lines +90 to +102
{#each nodes as node}
<g class={getNodeClass(node.id)}>
<rect
x={node.x - nodeWidth / 2}
y={node.y - nodeHeight / 2}
width={nodeWidth}
height={nodeHeight}
rx="2"
ry="2"
/>
<text x={node.x} y={node.y}>{node.label}</text>
</g>
{/each}
Copy link
Contributor

@graphite-app graphite-app bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This each block is missing a key attribute. Add a key using the node id: {#each nodes as node (node.id)}

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

@jumski jumski mentioned this pull request Nov 7, 2025
Closed
@jumski jumski force-pushed the feat-demo-split-code-to-separate branch from e917be1 to 247a4f4 Compare November 9, 2025 15:16
@jumski jumski force-pushed the feat-demo-improve-modal-copy branch from 33c05f6 to 285cf2a Compare November 9, 2025 15:16
@jumski jumski mentioned this pull request Nov 9, 2025
Closed
@jumski jumski force-pushed the feat-demo-improve-modal-copy branch from 285cf2a to fb04517 Compare November 10, 2025 16:42
@jumski jumski force-pushed the feat-demo-split-code-to-separate branch from 247a4f4 to e7e6e77 Compare November 10, 2025 16:42
This was referenced Nov 10, 2025
Closed
Closed
Closed
Closed
@jumski jumski force-pushed the feat-demo-improve-modal-copy branch from fb04517 to e03fcc0 Compare November 10, 2025 20:45
@jumski jumski force-pushed the feat-demo-split-code-to-separate branch from e7e6e77 to 79752ff Compare November 10, 2025 20:45
@jumski jumski force-pushed the feat-demo-split-code-to-separate branch from 79752ff to 9130808 Compare November 10, 2025 23:37
@jumski jumski force-pushed the feat-demo-improve-modal-copy branch from e03fcc0 to be528e2 Compare November 10, 2025 23:37
@jumski jumski force-pushed the feat-demo-improve-modal-copy branch from be528e2 to b90bf4f Compare November 11, 2025 14:38
This was referenced Nov 11, 2025
Closed
Closed
Closed
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2025 •
edited
Loading

Merge activity

  • Nov 11, 8:50 PM UTC: jumski added this pull request to the Graphite merge queue.
  • Nov 11, 8:53 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #289.
  • Nov 11, 8:54 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #289.
  • Nov 11, 9:05 PM UTC: jumski added this pull request to the Graphite merge queue.
  • Nov 11, 9:06 PM UTC: CI is running for this pull request on a draft pull request (#362) due to your merge queue CI optimization settings.
  • Nov 11, 9:07 PM UTC: Merged by the Graphite merge queue via draft PR: #362.

graphite-app bot pushed a commit that referenced this pull request Nov 11, 2025
@jumski
feat: demo improve modal copy (#327)
cb8916c
@graphite-app graphite-app bot closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jumski