Correct way to set env in docker container

DenKoren · DenKoren · commit 981f63fb8939 · 2025-11-12T20:54:00.000+03:00
diff --git a/builder/src/build.ts b/builder/src/build.ts
@@ -86,14 +86,12 @@ async function buildInDocker(): Promise<void> {
     '--rm',
     '--volume', `${util.repoRoot}:/app`,
     '--env', `FIX_PERMS=${process.getuid!()}:${process.getgid!()}`,
-    tagName,
-    `/app/${util.packageDirName}`
   ]
   if (isTestRun) {
     runArgs.push('--env', 'TEST_RUN=true');
   }
 
-  await util.runCommand('docker', ['run', ...runArgs]);
+  await util.runCommand('docker', ['run', ...runArgs, tagName, `/app/${util.packageDirName}`]);
 }
 
 async function buildFromSources(version: string, osType: util.OS, archType: util.Arch, installDir: string): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -86,14 +86,12 @@ async function buildInDocker(): Promise<void> {`
`86`	`86`	`'--rm',`
`87`	`87`	'--volume', `${util.repoRoot}:/app`,
`88`	`88`	'--env', `FIX_PERMS=${process.getuid!()}:${process.getgid!()}`,
`89`		`- tagName,`
`90`		- `/app/${util.packageDirName}`
`91`	`89`	`]`
`92`	`90`	`if (isTestRun) {`
`93`	`91`	`runArgs.push('--env', 'TEST_RUN=true');`
`94`	`92`	`}`
`95`	`93`
`96`		`- await util.runCommand('docker', ['run', ...runArgs]);`
	`94`	+ await util.runCommand('docker', ['run', ...runArgs, tagName, `/app/${util.packageDirName}`]);
`97`	`95`	`}`
`98`	`96`
`99`	`97`	`async function buildFromSources(version: string, osType: util.OS, archType: util.Arch, installDir: string): Promise<void> {`