v4.10.4 release candidate (#2328)

* Start v4.10.4 release candidate

* Bugfix for guide logic added to accomodate new ggplot2 guide logic

Issue was silently introduced by #2315, but didn't become an issue until tidyverse/ggplot2@851233f

* Update snapshots

Author: cpsievert

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: plotly
 Title: Create Interactive Web Graphics via 'plotly.js'
-Version: 4.10.3.9000
+Version: 4.10.4
 Authors@R: c(person("Carson", "Sievert", role = c("aut", "cre"),
     email = "cpsievert1@gmail.com", comment = c(ORCID = "0000-0002-4958-2844")),
     person("Chris", "Parmer", role = "aut",

NEWS.md

@@ -1,4 +1,4 @@
-# plotly (development version)
+# 4.10.4
 
 ## Improvements
 

R/ggplotly.R

@@ -1005,7 +1005,7 @@ gg2list <- function(p, width = NULL, height = NULL,
     theme$legend.box.just <- theme$legend.box.just %||% c("center", "center")
     # scales -> data for guides
     gdefs <- if (inherits(plot$guides, "ggproto")) {
-      get_gdefs_ggproto(npscales$scales, theme, plot, layers, data)
+      get_gdefs_ggproto(npscales$scales, theme, plot, layers, layer_data)
     } else {
       get_gdefs(scales, theme, plot, layers)
     }

inst/examples/shiny/event_data/tests/shinytest/mytest-expected/001.json

@@ -430,9 +430,9 @@
         },
         {
           "name": "crosstalk",
-          "version": "1.2.0",
+          "version": "1.2.1",
           "src": {
-            "href": "crosstalk-1.2.0"
+            "href": "crosstalk-1.2.1"
           },
           "meta": null,
           "script": "js/crosstalk.min.js",

inst/examples/shiny/event_data/tests/shinytest/mytest-expected/002.json

@@ -448,9 +448,9 @@
         },
         {
           "name": "crosstalk",
-          "version": "1.2.0",
+          "version": "1.2.1",
           "src": {
-            "href": "crosstalk-1.2.0"
+            "href": "crosstalk-1.2.1"
           },
           "meta": null,
           "script": "js/crosstalk.min.js",

inst/examples/shiny/event_data/tests/shinytest/mytest-expected/003.json

@@ -452,9 +452,9 @@
         },
         {
           "name": "crosstalk",
-          "version": "1.2.0",
+          "version": "1.2.1",
           "src": {
-            "href": "crosstalk-1.2.0"
+            "href": "crosstalk-1.2.1"
           },
           "meta": null,
           "script": "js/crosstalk.min.js",

inst/examples/shiny/event_data/tests/shinytest/mytest-expected/004.json

@@ -453,9 +453,9 @@
         },
         {
           "name": "crosstalk",
-          "version": "1.2.0",
+          "version": "1.2.1",
           "src": {
-            "href": "crosstalk-1.2.0"
+            "href": "crosstalk-1.2.1"
           },
           "meta": null,
           "script": "js/crosstalk.min.js",