Remove feature gates

Author: simolus3

.cargo/config.toml

@@ -3,7 +3,7 @@
 # It was to fix this error when loading the loadable extension:
 #   undefined symbol: _Unwind_Resume
 # Now, we instead build using:
-#   -Z build-std=panic_abort,core,alloc
+#   -Z build-std=panic_immediate_abort,core,alloc
 # This fixes the same issue. We still keep -lgcc_eh,
 # to support manual builds without -Z build-std.
 
@@ -17,6 +17,13 @@
 #   173K, loading works
 # Conclusion: -lgcc_eh has no effect when using -Z build-std.
 
+[profile.release]
+panic = "immediate-abort"
+
+[unstable]
+panic-immediate-abort = true
+build-std = ["core", "alloc", "panic_abort"]
+
 [target.'cfg(target_os = "linux")']
 rustflags = [
     "-C", "link-arg=-lgcc_eh",

crates/core/src/lib.rs

@@ -1,7 +1,4 @@
 #![no_std]
-#![feature(btree_set_entry)]
-#![feature(vec_into_raw_parts)]
-
 extern crate alloc;
 
 use core::ffi::{c_char, c_int};

crates/core/src/state.rs

@@ -63,7 +63,12 @@ impl DatabaseState {
 
     pub fn track_update(&self, tbl: &str) {
         let mut set = self.pending_updates.borrow_mut();
-        set.get_or_insert_with(tbl, str::to_string);
+        // TODO: Use set.get_or_insert_with(tbl, str::to_string) after btree_set_entry is stable,
+        // https://github.com/rust-lang/rust/issues/133549
+        if !set.contains(tbl) {
+            // Check whether the set contains the entry first to avoid an unconditional allocation.
+            set.insert(tbl.to_string());
+        }
     }
 
     pub fn track_rollback(&self) {

crates/core/src/sync/sync_status.rs

@@ -427,8 +427,11 @@ impl ActiveStreamSubscription {
     }
 
     pub fn mark_associated_with_bucket(&mut self, bucket: &OwnedBucketChecksum) {
-        self.associated_buckets
-            .get_or_insert_with(&bucket.bucket, |key| key.clone());
+        // This avoids an allocation if the bucket is already tracked. TODO: Use get_or_insert_with
+        // after https://github.com/rust-lang/rust/issues/133549 is stable.
+        if !self.associated_buckets.contains(&bucket.bucket) {
+            self.associated_buckets.insert(bucket.bucket.clone());
+        }
 
         self.priority = Some(match self.priority {
             None => bucket.priority,

crates/loadable/Cargo.toml

@@ -21,4 +21,5 @@ default-features = false
 features = []
 
 [features]
+nightly = []
 default = ["powersync_core/loadable_extension", "sqlite_nostd/loadable_extension", "powersync_core/getrandom"]

crates/loadable/src/lib.rs

@@ -1,8 +1,6 @@
 #![no_std]
-#![feature(vec_into_raw_parts)]
-#![feature(core_intrinsics)]
 #![allow(internal_features)]
-#![feature(lang_items)]
+#![cfg_attr(feature = "nightly", feature(core_intrinsics))]
 
 extern crate alloc;
 
@@ -20,12 +18,16 @@ static ALLOCATOR: SQLite3Allocator = SQLite3Allocator {};
 
 // Custom Panic handler for WASM and other no_std builds
 #[cfg(not(test))]
-#[panic_handler]
-fn panic(_info: &core::panic::PanicInfo) -> ! {
-    core::intrinsics::abort()
-}
+mod panic_handler {
+    #[cfg(feature = "nightly")]
+    #[panic_handler]
+    fn panic(_info: &core::panic::PanicInfo) -> ! {
+        core::intrinsics::abort()
+    }
 
-#[cfg(not(target_family = "wasm"))]
-#[cfg(not(test))]
-#[lang = "eh_personality"]
-extern "C" fn eh_personality() {}
+    #[cfg(not(feature = "nightly"))]
+    #[panic_handler]
+    fn panic(_info: &core::panic::PanicInfo) -> ! {
+        loop {}
+    }
+}

crates/static/Cargo.toml

@@ -21,4 +21,5 @@ default-features = false
 features = []
 
 [features]
+nightly = []
 default = ["powersync_core/static", "powersync_core/omit_load_extension", "sqlite_nostd/omit_load_extension"]

crates/static/src/lib.rs

@@ -1,8 +1,6 @@
 #![no_std]
-#![feature(vec_into_raw_parts)]
-#![feature(core_intrinsics)]
 #![allow(internal_features)]
-#![feature(lang_items)]
+#![cfg_attr(feature = "nightly", feature(core_intrinsics))]
 
 extern crate alloc;
 
@@ -20,7 +18,16 @@ static ALLOCATOR: SQLite3Allocator = SQLite3Allocator {};
 
 // Custom Panic handler for WASM and other no_std builds
 #[cfg(not(test))]
-#[panic_handler]
-fn panic(_info: &core::panic::PanicInfo) -> ! {
-    core::intrinsics::abort()
+mod panic_handler {
+    #[cfg(feature = "nightly")]
+    #[panic_handler]
+    fn panic(_info: &core::panic::PanicInfo) -> ! {
+        core::intrinsics::abort()
+    }
+
+    #[cfg(not(feature = "nightly"))]
+    #[panic_handler]
+    fn panic(_info: &core::panic::PanicInfo) -> ! {
+        loop {}
+    }
 }

tool/build_linux.sh

@@ -5,8 +5,8 @@ function compile() {
   local triple=$1
   local suffix=$2
 
-  cargo build -p powersync_loadable -Z build-std=panic_abort,core,alloc --release --target $triple
-  cargo build -p powersync_static -Z build-std=panic_abort,core,alloc --release --target $triple
+  cargo build -p powersync_loadable --features nightly,default --release --target $triple
+  cargo build -p powersync_static --features nightly,default --release --target $triple
 
   mv "target/$triple/release/libpowersync.so" "libpowersync_$suffix.linux.so"
   mv "target/$triple/release/libpowersync.a" "libpowersync_$suffix.linux.a"

tool/build_macos.sh

@@ -6,8 +6,8 @@ function compile() {
   local suffix=$2
   local os=$3
 
-  cargo build -p powersync_loadable -Z build-std=panic_abort,core,alloc --release --target $triple
-  cargo build -p powersync_static -Z build-std=panic_abort,core,alloc --release --target $triple
+  cargo build -p powersync_loadable --features nightly,default --release --target $triple
+  cargo build -p powersync_static --features nightly,default --release --target $triple
 
   mv "target/$triple/release/libpowersync.dylib" "libpowersync_$suffix.$os.dylib"
   mv "target/$triple/release/libpowersync.a" "libpowersync_$suffix.$os.a"