Remove all usage of new Buffer(); use Buffer.from()/Buffer.alloc()

Fixes #99

Author: RyanZim

src/bytebuffer.js

@@ -32,7 +32,7 @@ var ByteBuffer = function(capacity, littleEndian, noAssert) {
      * @type {!Buffer}
      * @expose
      */
-    this.buffer = capacity === 0 ? EMPTY_BUFFER : new Buffer(capacity);
+    this.buffer = capacity === 0 ? EMPTY_BUFFER : Buffer.alloc(capacity);
     //? } else {
 
     /**

src/encodings/base64.js

@@ -46,7 +46,7 @@ ByteBufferPrototype.toBase64 = function(begin, end) {
  */
 ByteBuffer.fromBase64 = function(str, littleEndian) {
     //? if (NODE) {
-    return ByteBuffer.wrap(new Buffer(str, "base64"), littleEndian);
+    return ByteBuffer.wrap(Buffer.from(str, "base64"), littleEndian);
     //? } else {
     if (typeof str !== 'string')
         throw TypeError("str");

src/encodings/binary.js

@@ -49,7 +49,7 @@ ByteBufferPrototype.toBinary = function(begin, end) {
  */
 ByteBuffer.fromBinary = function(str, littleEndian) {
     //? if (NODE) {
-    return ByteBuffer.wrap(new Buffer(str, "binary"), littleEndian);
+    return ByteBuffer.wrap(Buffer.from(str, "binary"), littleEndian);
     //? } else {
     if (typeof str !== 'string')
         throw TypeError("str");

src/encodings/hex.js

@@ -51,7 +51,7 @@ ByteBuffer.fromHex = function(str, littleEndian, noAssert) {
     }
     //? if (NODE) {
     var bb = new ByteBuffer(0, littleEndian, true);
-    bb.buffer = new Buffer(str, "hex");
+    bb.buffer = Buffer.from(str, "hex");
     bb.limit = bb.buffer.length;
     //? } else {
     var k = str.length,

src/encodings/utf8.js

@@ -52,7 +52,7 @@ ByteBuffer.fromUTF8 = function(str, littleEndian, noAssert) {
             throw TypeError("Illegal str: Not a string");
     //? if (NODE) {
     var bb = new ByteBuffer(0, littleEndian, noAssert);
-    bb.buffer = new Buffer(str, "utf8");
+    bb.buffer = Buffer.from(str, "utf8");
     bb.limit = bb.buffer.length;
     //? } else {
     var bb = new ByteBuffer(utfx.calculateUTF16asUTF8(stringSource(str), true)[1], littleEndian, noAssert),

src/helpers.js

@@ -5,7 +5,7 @@
  * @type {!Buffer}
  * @inner
  */
-var EMPTY_BUFFER = new Buffer(0);
+var EMPTY_BUFFER = Buffer.alloc(0);
 //? } else {
 
 /**

src/methods/clone.js

@@ -9,7 +9,7 @@ ByteBufferPrototype.clone = function(copy) {
     var bb = new ByteBuffer(0, this.littleEndian, this.noAssert);
     if (copy) {
         //? if (NODE) {
-        var buffer = new Buffer(this.buffer.length);
+        var buffer = Buffer.alloc(this.buffer.length);
         this.buffer.copy(buffer);
         bb.buffer = buffer;
         //? } else {

src/methods/compact.js

@@ -26,7 +26,7 @@ ByteBufferPrototype.compact = function(begin, end) {
         return this;
     }
     //? if (NODE) {
-    var buffer = new Buffer(len);
+    var buffer = Buffer.alloc(len);
     this.buffer.copy(buffer, 0, begin, end);
     this.buffer = buffer;
     //? } else if (DATAVIEW) {

src/methods/prepend.js

@@ -33,7 +33,7 @@ ByteBufferPrototype.prepend = function(source, encoding, offset) {
     var diff = len - offset;
     if (diff > 0) { // Not enough space before offset, so resize + move
         //? if (NODE) {
-        var buffer = new Buffer(this.buffer.length + diff);
+        var buffer = Buffer.alloc(this.buffer.length + diff);
         this.buffer.copy(buffer, len, offset, this.buffer.length);
         this.buffer = buffer;
         //? } else if (DATAVIEW) {

src/methods/resize.js

@@ -15,7 +15,7 @@ ByteBufferPrototype.resize = function(capacity) {
     }
     //? if (NODE) {
     if (this.buffer.length < capacity) {
-        var buffer = new Buffer(capacity);
+        var buffer = Buffer.alloc(capacity);
         this.buffer.copy(buffer);
         this.buffer = buffer;
     }