Remove unnecessary IOExceptions #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a ByteBuffer instead of a ByteArrayOutputStream we can get ride of cumbersome IOException. We also get an extra boost for free. Running TestHyperLogLog.testSerialization in a caliper micro-benchmark shows that the ByteBuffer version is two times faster.
By using a ByteBuffer instead of a ByteArrayOutputStream we can get ride of cumbersome IOException. We also get an extra boost for free.
We can safely try/catch exceptions in ExternalizableUtil since ByteArrayOutputStream never throws IOException.
All implementations have been cleaned. Their is no reason for a serializer to throw IOException and users don't want to criple their code with unecessary exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. addthis#34