Merge pull request #3 from purescript-node/https-client

Use HTTPS where necessary in HTTP.Client

Author: paf31

bower.json

@@ -20,6 +20,7 @@
     "purescript-maps": "^0.5.4",
     "purescript-options": "^0.6.0",
     "purescript-unsafe-coerce": "^0.1.0",
-    "purescript-node-streams": "^0.3.0"
+    "purescript-node-streams": "^0.3.0",
+    "purescript-node-url": "^0.1.1"
   }
 }

src/Node/HTTP/Client.js

@@ -3,11 +3,13 @@
 // module Node.HTTP.Client
 
 var http = require('http');
+var https = require('https');
 
 exports.requestImpl = function(opts) {
   return function(k) {
     return function() {
-      return http.request(opts, function(res) {
+      var lib = opts.protocol === 'https:' ? https : http;
+      return lib.request(opts, function(res) {
         k(res)();
       });
     };

src/Node/HTTP/Client.purs

@@ -31,6 +31,7 @@ import Data.StrMap (StrMap())
 
 import Node.HTTP (HTTP())
 import Node.Stream (Readable, Writable)
+import Node.URL as URL
 
 import Control.Monad.Eff (Eff)
 
@@ -84,7 +85,7 @@ request = requestImpl <<< options
 
 -- | Make a HTTP request from a URI string and response callback.
 requestFromURI :: forall eff. String -> (Response -> Eff (http :: HTTP | eff) Unit) -> Eff (http :: HTTP | eff) Request
-requestFromURI = requestImpl <<< toForeign
+requestFromURI = requestImpl <<< toForeign <<< URL.parse
 
 -- | Create a writable stream from a request object.
 requestAsStream :: forall eff r. Request -> Writable r (http :: HTTP | eff)

test/Main.purs

@@ -15,14 +15,14 @@ import Node.Encoding
 foreign import stdout :: forall eff r. Writable r eff
 
 main = do
+  testBasic
+  testHttps
+
+testBasic = do
   server <- createServer respond
   listen server 8080 $ void do
     log "Listening on port 8080."
-    req <- Client.requestFromURI "http://localhost:8080/" \response -> void do
-      log "Response from GET /:"
-      let responseStream = Client.responseAsStream response
-      pipe responseStream stdout
-    end (Client.requestAsStream req) (return unit)
+    simpleReq "http://localhost:8080"
   where
   respond req res = do
     setStatusCode res 200
@@ -41,3 +41,14 @@ main = do
         writeString outputStream UTF8 html(return unit)
         end outputStream (return unit)
       "POST" -> void $ pipe inputStream outputStream
+
+testHttps =
+  simpleReq "https://api.github.com"
+
+simpleReq uri = do
+  log ("GET " <> uri <> ":")
+  req <- Client.requestFromURI uri \response -> void do
+    log "Response:"
+    let responseStream = Client.responseAsStream response
+    pipe responseStream stdout
+  end (Client.requestAsStream req) (return unit)