Merge branch 'dev'

Author: janiversen

.github/workflows/ci.yml

@@ -94,7 +94,7 @@ jobs:
         run: pip install -e . -r requirements.txt
 
       - name: pytest
-        run: pytest -n0 --cov=pymodbus --cov=test --cov-report=term-missing --cov-report=xml -v --full-trace --timeout=20
+        run: pytest -n0  -v --full-trace --timeout=20
 
   analyze:
     name: Analyze Python

.pre-commit-config.yaml

@@ -12,7 +12,7 @@ repos:
     -   id: check-added-large-files
 # run ruff with --fix before black
 -   repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: 'v0.0.263'
+    rev: 'v0.0.277'
     hooks:
     -   id: ruff
         args: [--fix, --exit-non-zero-on-fix]

API_changes.rst

@@ -2,6 +2,12 @@
 PyModbus - API changes.
 =======================
 
+-------------
+Version 3.4.1
+-------------
+
+No changes.
+
 -------------
 Version 3.4.0
 -------------

CHANGELOG.rst

@@ -1,3 +1,27 @@
+version 3.4.1
+----------------------------------------------------------
+* Fix serial startup problems. (#1701)
+* pass source_address in tcp client. (#1700)
+* serial server use source_address[0]. (#1699)
+* Examples coverage nearly 100%. (#1694)
+* new async serial (#1681)
+* Docker is not supported (lack of maintainer). (#1693)
+* Forwarder write_coil --> write_coil. (#1691)
+* Change default source_address to (0.0.0.0, 502) (#1690)
+* Update ruff to 0.0.277 (#1689)
+* Fix dict comprehension (#1687)
+* Removed `requests` dependency from `contrib/explain.py`  (#1688)
+* Fix broken test (#1685)
+* Fix readme badges (#1682)
+* Bump aiohttp from 3.8.3 to 3.8.5 (#1680)
+* pygments from 2.14.0 to 2.15.0 (#1677)
+
+Thanks to:
+    Alex
+    James Braza
+    jan iversen
+
+
 version 3.4.0
 ----------------------------------------------------------
 * Prepare v3.4.0.

README.rst

@@ -6,23 +6,20 @@ There are challenges small and large not only programming but also documentation
 
 .. image:: https://github.com/pymodbus-dev/pymodbus/actions/workflows/ci.yml/badge.svg?branch=dev
    :target: https://github.com/pymodbus-dev/pymodbus/actions/workflows/ci.yml
- .. image:: https://readthedocs.org/projects/pymodbus/badge/?version=latest
+.. image:: https://readthedocs.org/projects/pymodbus/badge/?version=latest
    :target: https://pymodbus.readthedocs.io/en/latest/?badge=latest
    :alt: Documentation Status
 .. image:: https://pepy.tech/badge/pymodbus
    :target: https://pepy.tech/project/pymodbus
    :alt: Downloads
-.. image:: https://ghcr-badge.deta.dev/pymodbus-dev/pymodbus/tags?label=Docker
-   :target: https://github.com/pymodbus-dev/pymodbus/pkgs/container/pymodbus
-   :alt: Docker Tags
 
 ------------------------------------------------------------
 Supported versions
 ------------------------------------------------------------
 
 Version `2.5.3 <https://github.com/pymodbus-dev/pymodbus/releases/tag/v2.5.3>`_ is the last 2.x release (python >= 2.7, no longer supported).
 
-Version `3.4.0 <https://github.com/pymodbus-dev/pymodbus/releases/tag/v3.4.0>`_ is the current release (Tested with Python >= 3.8).
+Version `3.4.1 <https://github.com/pymodbus-dev/pymodbus/releases/tag/v3.4.1>`_ is the current release (Tested with Python >= 3.8).
 
 .. important::
    All API changes after 3.0.0 are documented in `API_changes.rst <https://github.com/pymodbus-dev/pymodbus/blob/dev/API_changes.rst>`_

doc/source/examples.rst

@@ -54,10 +54,6 @@ Asynchronous server
 ^^^^^^^^^^^^^^^^^^^
 .. literalinclude:: ../../examples/server_async.py
 
-Build bcd Payload
-^^^^^^^^^^^^^^^^^
-.. literalinclude:: ../../examples/build_bcd_payload.py
-
 Callback Server example
 ^^^^^^^^^^^^^^^^^^^^^^^
 .. literalinclude:: ../../examples/server_callback.py

examples/build_bcd_payload.py

@@ -1,5 +1,5 @@
 #!/usr/bin/env python3
-"""Pymodbus aynchronous client example.
+"""Pymodbus asynchronous client example.
 
 An example of a asynchronous client.
 
@@ -143,6 +143,11 @@ async def run_a_few_calls(client):
         pass
 
 
+async def main(cmdline=None):
+    """Combine setup and run."""
+    testclient = setup_async_client(description="Run client.", cmdline=cmdline)
+    await run_async_client(testclient, modbus_calls=run_a_few_calls)
+
+
 if __name__ == "__main__":
-    testclient = setup_async_client(description="Run asynchronous client.")
-    asyncio.run(run_async_client(testclient, modbus_calls=run_a_few_calls), debug=True)
+    asyncio.run(main(), debug=True)  # pragma: no cover