Skip to content

Commit 5a50305

Browse files
committed
refactor: removed unnecessary check
1 parent b5a27f0 commit 5a50305

File tree

3 files changed

+12
-21
lines changed

3 files changed

+12
-21
lines changed

cloud/gcloud/logger.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package gcloud
22

33
import (
4-
gologger "github.com/ralvarezdev/go-logger"
54
gologgermode "github.com/ralvarezdev/go-logger/mode"
65
gologgermodenamed "github.com/ralvarezdev/go-logger/mode/named"
76
"google.golang.org/grpc/credentials/oauth"
@@ -14,13 +13,11 @@ type Logger struct {
1413

1514
// NewLogger is the logger for Google Cloud
1615
func NewLogger(header string, modeLogger gologgermode.Logger) (*Logger, error) {
17-
// Check if the logger is nil
18-
if modeLogger == nil {
19-
return nil, gologger.ErrNilLogger
20-
}
21-
2216
// Initialize the mode named logger
23-
namedLogger, _ := gologgermodenamed.NewDefaultLogger(header, modeLogger)
17+
namedLogger, err := gologgermodenamed.NewDefaultLogger(header, modeLogger)
18+
if err != nil {
19+
return nil, err
20+
}
2421

2522
return &Logger{logger: namedLogger}, nil
2623
}

env/logger.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package env
22

33
import (
4-
gologger "github.com/ralvarezdev/go-logger"
54
gologgermode "github.com/ralvarezdev/go-logger/mode"
65
gologgermodenamed "github.com/ralvarezdev/go-logger/mode/named"
76
)
@@ -13,13 +12,11 @@ type Logger struct {
1312

1413
// NewLogger creates a new environment logger
1514
func NewLogger(header string, modeLogger gologgermode.Logger) (*Logger, error) {
16-
// Check if the logger is nil
17-
if modeLogger == nil {
18-
return nil, gologger.ErrNilLogger
19-
}
20-
2115
// Initialize the mode named logger
22-
namedLogger, _ := gologgermodenamed.NewDefaultLogger(header, modeLogger)
16+
namedLogger, err := gologgermodenamed.NewDefaultLogger(header, modeLogger)
17+
if err != nil {
18+
return nil, err
19+
}
2320

2421
return &Logger{logger: namedLogger}, nil
2522
}

http/listener/logger.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package listener
22

33
import (
4-
gologger "github.com/ralvarezdev/go-logger"
54
gologgermode "github.com/ralvarezdev/go-logger/mode"
65
gologgermodenamed "github.com/ralvarezdev/go-logger/mode/named"
76
)
@@ -13,13 +12,11 @@ type Logger struct {
1312

1413
// NewLogger creates a new listener logger
1514
func NewLogger(header string, modeLogger gologgermode.Logger) (*Logger, error) {
16-
// Check if the logger is nil
17-
if modeLogger == nil {
18-
return nil, gologger.ErrNilLogger
19-
}
20-
2115
// Initialize the mode named logger
22-
namedLogger, _ := gologgermodenamed.NewDefaultLogger(header, modeLogger)
16+
namedLogger, err := gologgermodenamed.NewDefaultLogger(header, modeLogger)
17+
if err != nil {
18+
return nil, err
19+
}
2320

2421
return &Logger{logger: namedLogger}, nil
2522
}

0 commit comments

Comments
 (0)