Skip to content

Fix openSettings context access #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix openSettings context access #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b879788
Fix openSettings context access
Luna712 Oct 23, 2025
174fc02
Update
Luna712 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ExampleProvider/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ cloudstream {
authors = listOf("Cloudburst", "Luna712")

/**
* Status int as one of the following:
* 0: Down
* 1: Ok
* 2: Slow
* 3: Beta-only
**/
* Status int as one of the following:
* 0: Down
* 1: Ok
* 2: Slow
* 3: Beta-only
*/
status = 1 // Will be 3 if unspecified

tvTypes = listOf("Movie")
Expand Down
11 changes: 3 additions & 8 deletions ExampleProvider/src/main/kotlin/com/example/ExamplePlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,14 @@ import com.lagradost.cloudstream3.plugins.Plugin

@CloudstreamPlugin
class ExamplePlugin: Plugin() {
private var activity: AppCompatActivity? = null

override fun load(context: Context) {
activity = context as? AppCompatActivity

// All providers should be added in this manner
registerMainAPI(ExampleProvider())

openSettings = {
openSettings = { ctx ->
val activity = ctx as AppCompatActivity
Copy link

@fire-light42 fire-light42 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a a cast that might fail if we change how context is passed. Please use as?

Copy link
Contributor Author

@Luna712 Luna712 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think it was possible to fail for 2 reasons.

  1. It's passed as requireContext not to great but doesn't matter because...
  2. it catches any Throwable so it would handle bad context or failed casting automatically

I mean I can use a check like that but just didn't think we needed to.

val frag = BlankFragment(this)
activity?.let {
frag.show(it.supportFragmentManager, "Frag")
}
frag.show(activity.supportFragmentManager, "Frag")
}
}
}