Fix one more build issue on future version of Kotlin #2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a warning on Kotlin 2.3 and will be an error in 2.4: `Type annotation class 'Nullable' of the inferred type is inaccessible. Check the module classpath for missing or conflicting dependencies. This will become an error in language version 2.4.`
Collaborator
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
I do not understand what exactly is wrong with the current code. Moreover, are you sure that .data is semantically equivalent to .html?
Contributor
Author
According to docs in jsoup, data() is the correct usage to pull from a script tag. And its used elsewhere here also. As for what is wrong, it just couldn't understand that selectFirst is nullable with the Nullable annotation in jsoup without it being explicit using data inline which, in my opinion is actually better anyway. |
fire-light42
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a warning on Kotlin 2.3 and will be an error in 2.4:
Type annotation class 'Nullable' of the inferred type is inaccessible. Check the module classpath for missing or conflicting dependencies. This will become an error in language version 2.4.