Elide conversion of receiver, extension or inline map, trailing implicit args, in DropForMap #23416
Conversation
som-snytt
force-pushed
the
issue/23409-for-map
branch
from
38686ed to
14974ed
Compare
|
Handling inlined map at inlining works better. Edit: working on that. Edit: actually no, it's fine in DropForMap; at some point I just decided to lift out the reference to the binding of the receiver. |
|
The related PR because I had to read the code: "It's not bad code, it's just a style choice." |
som-snytt
force-pushed
the
issue/23409-for-map
branch
from
c121bd8 to
02fa81e
Compare
som-snytt
changed the title
|
I broke the one I didn't study the debug test yet. The test run saw the SO in community_c as well. Edit: also community_b. At least it fails very fast. Edit: Green check on test, but just missed the boat on |
som-snytt
force-pushed
the
issue/23409-for-map
branch
from
e9b0078 to
8691c9d
Compare
| bindings.collectFirst: | ||
| case vd: ValDef if f.sameTree(vd.rhs) => | ||
| expansion.find: | ||
| case Inlined(Thicket(Nil), Nil, Ident(ident)) => ident == vd.name |
There was a problem hiding this comment.
Would it be safer to compare symbols instead of names?
There was a problem hiding this comment.
Thanks, an excellent spot!
| // Extracts a fun from a possibly nested Apply with lambda and arbitrary implicit args. | ||
| // Specifically, an application `r.map(x => x)` is destructured into (r, map, args). | ||
| // If the receiver r was adapted, it is unwrapped. | ||
| // If `map` is an extension method, the nominal receiver is `args.head`. |
There was a problem hiding this comment.
| // Extracts a fun from a possibly nested Apply with lambda and arbitrary implicit args. | |
| // Specifically, an application `r.map(x => x)` is destructured into (r, map, args). | |
| // If the receiver r was adapted, it is unwrapped. | |
| // If `map` is an extension method, the nominal receiver is `args.head`. | |
| /** Extracts a fun from a possibly nested Apply with lambda and arbitrary implicit args. | |
| * Specifically, an application `r.map(x => x)` is destructured into (r, map, args). | |
| * If the receiver r was adapted, it is unwrapped. | |
| * If `map` is an extension method, the nominal receiver is `args.head`. | |
| */ |
| case MySome(x) => ??? //MySome(f(x)) | ||
| case MyNone => ??? //MyNone |
There was a problem hiding this comment.
Nice! This is way more elegant than my previous approach 😃
som-snytt
force-pushed
the
issue/23409-for-map
branch
from
8691c9d to
a663a2a
Compare
3 participants
Fixes #23409
If
mapis added to a type by conversion, consider dropping the conversion when dropping amapcall.Similarly, it doesn't matter if the method is an extension or inline: drop the map and preserve the nominal receiver.