Skip to content

Commit 100c7f0

Browse files
committed
Polishing.
Add author tags and issue number comment for new tests. See #3250 Signed-off-by: Chris Bono <chris.bono@broadcom.com>
1 parent 7e21112 commit 100c7f0

14 files changed

+89
-79
lines changed

src/main/java/org/springframework/data/redis/connection/ReactiveStringCommands.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1289,7 +1289,7 @@ default Mono<Long> bitPos(ByteBuffer key, boolean bit, Range<Long> range) {
12891289
}
12901290

12911291
/**
1292-
* Emmit the position of the first bit set to given {@code bit} in a string. Get the length of the value stored at
1292+
* Emit the position of the first bit set to given {@code bit} in a string. Get the length of the value stored at
12931293
* {@literal key}.
12941294
*
12951295
* @param commands must not be {@literal null}.

src/main/java/org/springframework/data/redis/connection/RedisStringCommands.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
* @author Christoph Strobl
3333
* @author Mark Paluch
3434
* @author Marcin Grzejszczak
35+
* @author Viktoriya Kutsarova
3536
* @see RedisCommands
3637
*/
3738
@NullUnmarked

src/main/java/org/springframework/data/redis/connection/jedis/JedisConverters.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
* @author Guy Korland
110110
* @author dengliming
111111
* @author John Blum
112+
* @author Viktoriya Kutsarova
112113
*/
113114
@SuppressWarnings("ConstantConditions")
114115
abstract class JedisConverters extends Converters {

src/main/java/org/springframework/data/redis/connection/lettuce/LettuceReactiveStringCommands.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
* @author Michele Mancioppi
5151
* @author John Blum
5252
* @author Marcin Grzejszczak
53+
* @author Viktoriya Kutsarova
5354
* @since 2.0
5455
*/
5556
class LettuceReactiveStringCommands implements ReactiveStringCommands {

src/main/java/org/springframework/data/redis/connection/lettuce/LettuceStringCommands.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
* @author dengliming
4141
* @author John Blum
4242
* @author Marcin Grzejszczak
43+
* @author Viktoriya Kutsarova
4344
* @since 2.0
4445
*/
4546
@NullUnmarked

src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
* @author Roman Osadchuk
118118
* @author Tihomir Mateev
119119
* @author Jeonggyu Choi
120+
* @author Viktoriya Kutsarova
120121
*/
121122
public abstract class AbstractConnectionIntegrationTests {
122123

@@ -571,7 +572,7 @@ void testBitOpNotMultipleSources() {
571572
.isThrownBy(() -> connection.bitOp(BitOperation.NOT, "key3", "key1", "key2"));
572573
}
573574

574-
@Test
575+
@Test // GH-3250
575576
void testBitOpDiff() {
576577

577578
actual.add(connection.set("key1", "foobar"));
@@ -580,7 +581,7 @@ void testBitOpDiff() {
580581
verifyResults(Arrays.asList(Boolean.TRUE, Boolean.TRUE, 6L));
581582
}
582583

583-
@Test
584+
@Test // GH-3250
584585
void testBitOpDiff1() {
585586

586587
actual.add(connection.set("key1", "foobar"));
@@ -589,7 +590,7 @@ void testBitOpDiff1() {
589590
verifyResults(Arrays.asList(Boolean.TRUE, Boolean.TRUE, 6L));
590591
}
591592

592-
@Test
593+
@Test // GH-3250
593594
void testBitOpAndor() {
594595

595596
actual.add(connection.set("key1", "foo"));
@@ -598,7 +599,7 @@ void testBitOpAndor() {
598599
verifyResults(Arrays.asList(Boolean.TRUE, Boolean.TRUE, 3L));
599600
}
600601

601-
@Test
602+
@Test // GH-3250
602603
void testBitOpOne() {
603604

604605
actual.add(connection.set("key1", "foo"));

src/test/java/org/springframework/data/redis/connection/DefaultStringRedisConnectionPipelineTests.java

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
* @author Ninad Divadkar
3939
* @author Mark Paluch
4040
* @author dengliming
41+
* @author Viktoriya Kutsarova
4142
*/
4243
public class DefaultStringRedisConnectionPipelineTests extends DefaultStringRedisConnectionTests {
4344

@@ -1010,85 +1011,85 @@ public void testBitOp() {
10101011
super.testBitOp();
10111012
}
10121013

1013-
@Test
1014+
@Test // GH-3250
10141015
public void testBitOpOrBytes() {
10151016
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10161017
super.testBitOpOrBytes();
10171018
}
10181019

1019-
@Test
1020+
@Test // GH-3250
10201021
public void testBitOpOr() {
10211022
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10221023
super.testBitOpOr();
10231024
}
10241025

1025-
@Test
1026+
@Test // GH-3250
10261027
public void testBitOpXorBytes() {
10271028
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10281029
super.testBitOpXorBytes();
10291030
}
10301031

1031-
@Test
1032+
@Test // GH-3250
10321033
public void testBitOpXor() {
10331034
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10341035
super.testBitOpXor();
10351036
}
10361037

1037-
@Test
1038+
@Test // GH-3250
10381039
public void testBitOpNotBytes() {
10391040
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10401041
super.testBitOpNotBytes();
10411042
}
10421043

1043-
@Test
1044+
@Test // GH-3250
10441045
public void testBitOpNot() {
10451046
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10461047
super.testBitOpNot();
10471048
}
10481049

1049-
@Test
1050+
@Test // GH-3250
10501051
public void testBitOpDiffBytes() {
10511052
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10521053
super.testBitOpDiffBytes();
10531054
}
10541055

1055-
@Test
1056+
@Test // GH-3250
10561057
public void testBitOpDiff() {
10571058
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10581059
super.testBitOpDiff();
10591060
}
10601061

1061-
@Test
1062+
@Test // GH-3250
10621063
public void testBitOpDiff1Bytes() {
10631064
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10641065
super.testBitOpDiff1Bytes();
10651066
}
10661067

1067-
@Test
1068+
@Test // GH-3250
10681069
public void testBitOpDiff1() {
10691070
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10701071
super.testBitOpDiff1();
10711072
}
10721073

1073-
@Test
1074+
@Test // GH-3250
10741075
public void testBitOpAndorBytes() {
10751076
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10761077
super.testBitOpAndorBytes();
10771078
}
10781079

1079-
@Test
1080+
@Test // GH-3250
10801081
public void testBitOpAndor() {
10811082
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10821083
super.testBitOpAndor();
10831084
}
10841085

1085-
@Test
1086+
@Test // GH-3250
10861087
public void testBitOpOneBytes() {
10871088
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10881089
super.testBitOpOneBytes();
10891090
}
10901091

1091-
@Test
1092+
@Test // GH-3250
10921093
public void testBitOpOne() {
10931094
doReturn(Collections.singletonList(5L)).when(nativeConnection).closePipeline();
10941095
super.testBitOpOne();

src/test/java/org/springframework/data/redis/connection/DefaultStringRedisConnectionPipelineTxTests.java

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
* @author Ninad Divadkar
3838
* @author Mark Paluch
3939
* @author dengliming
40+
* @author Viktoriya Kutsarova
4041
*/
4142
public class DefaultStringRedisConnectionPipelineTxTests extends DefaultStringRedisConnectionTxTests {
4243

@@ -1025,85 +1026,85 @@ public void testBitOp() {
10251026
super.testBitOp();
10261027
}
10271028

1028-
@Test
1029+
@Test // GH-3250
10291030
public void testBitOpOrBytes() {
10301031
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10311032
super.testBitOpOrBytes();
10321033
}
10331034

1034-
@Test
1035+
@Test // GH-3250
10351036
public void testBitOpOr() {
10361037
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10371038
super.testBitOpOr();
10381039
}
10391040

1040-
@Test
1041+
@Test // GH-3250
10411042
public void testBitOpXorBytes() {
10421043
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10431044
super.testBitOpXorBytes();
10441045
}
10451046

1046-
@Test
1047+
@Test // GH-3250
10471048
public void testBitOpXor() {
10481049
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10491050
super.testBitOpXor();
10501051
}
10511052

1052-
@Test
1053+
@Test // GH-3250
10531054
public void testBitOpNotBytes() {
10541055
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10551056
super.testBitOpNotBytes();
10561057
}
10571058

1058-
@Test
1059+
@Test // GH-3250
10591060
public void testBitOpNot() {
10601061
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10611062
super.testBitOpNot();
10621063
}
10631064

1064-
@Test
1065+
@Test // GH-3250
10651066
public void testBitOpDiffBytes() {
10661067
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10671068
super.testBitOpDiffBytes();
10681069
}
10691070

1070-
@Test
1071+
@Test // GH-3250
10711072
public void testBitOpDiff() {
10721073
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10731074
super.testBitOpDiff();
10741075
}
10751076

1076-
@Test
1077+
@Test // GH-3250
10771078
public void testBitOpDiff1Bytes() {
10781079
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10791080
super.testBitOpDiff1Bytes();
10801081
}
10811082

1082-
@Test
1083+
@Test // GH-3250
10831084
public void testBitOpDiff1() {
10841085
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10851086
super.testBitOpDiff1();
10861087
}
10871088

1088-
@Test
1089+
@Test // GH-3250
10891090
public void testBitOpAndorBytes() {
10901091
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10911092
super.testBitOpAndorBytes();
10921093
}
10931094

1094-
@Test
1095+
@Test // GH-3250
10951096
public void testBitOpAndor() {
10961097
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
10971098
super.testBitOpAndor();
10981099
}
10991100

1100-
@Test
1101+
@Test // GH-3250
11011102
public void testBitOpOneBytes() {
11021103
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
11031104
super.testBitOpOneBytes();
11041105
}
11051106

1106-
@Test
1107+
@Test // GH-3250
11071108
public void testBitOpOne() {
11081109
doReturn(Collections.singletonList(Collections.singletonList(5L))).when(nativeConnection).closePipeline();
11091110
super.testBitOpOne();

src/test/java/org/springframework/data/redis/connection/DefaultStringRedisConnectionTests.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
* @author Mark Paluch
7979
* @author dengliming
8080
* @author ihaohong
81+
* @author Viktoriya Kutsarova
8182
*/
8283
@ExtendWith(MockitoExtension.class)
8384
@MockitoSettings(strictness = Strictness.LENIENT)
@@ -1308,56 +1309,56 @@ public void testBitOpNot() {
13081309
verifyResults(Collections.singletonList(5L));
13091310
}
13101311

1311-
@Test
1312+
@Test // GH-3250
13121313
public void testBitOpDiffBytes() {
13131314
doReturn(5L).when(nativeConnection).bitOp(BitOperation.DIFF, fooBytes, barBytes);
13141315
actual.add(connection.bitOp(BitOperation.DIFF, fooBytes, barBytes));
13151316
verifyResults(Collections.singletonList(5L));
13161317
}
13171318

1318-
@Test
1319+
@Test // GH-3250
13191320
public void testBitOpDiff() {
13201321
doReturn(5L).when(nativeConnection).bitOp(BitOperation.DIFF, fooBytes, barBytes);
13211322
actual.add(connection.bitOp(BitOperation.DIFF, foo, bar));
13221323
verifyResults(Collections.singletonList(5L));
13231324
}
13241325

1325-
@Test
1326+
@Test // GH-3250
13261327
public void testBitOpDiff1Bytes() {
13271328
doReturn(5L).when(nativeConnection).bitOp(BitOperation.DIFF1, fooBytes, barBytes);
13281329
actual.add(connection.bitOp(BitOperation.DIFF1, fooBytes, barBytes));
13291330
verifyResults(Collections.singletonList(5L));
13301331
}
13311332

1332-
@Test
1333+
@Test // GH-3250
13331334
public void testBitOpDiff1() {
13341335
doReturn(5L).when(nativeConnection).bitOp(BitOperation.DIFF1, fooBytes, barBytes);
13351336
actual.add(connection.bitOp(BitOperation.DIFF1, foo, bar));
13361337
verifyResults(Collections.singletonList(5L));
13371338
}
13381339

1339-
@Test
1340+
@Test // GH-3250
13401341
public void testBitOpAndorBytes() {
13411342
doReturn(5L).when(nativeConnection).bitOp(BitOperation.ANDOR, fooBytes, barBytes);
13421343
actual.add(connection.bitOp(BitOperation.ANDOR, fooBytes, barBytes));
13431344
verifyResults(Collections.singletonList(5L));
13441345
}
13451346

1346-
@Test
1347+
@Test // GH-3250
13471348
public void testBitOpAndor() {
13481349
doReturn(5L).when(nativeConnection).bitOp(BitOperation.ANDOR, fooBytes, barBytes);
13491350
actual.add(connection.bitOp(BitOperation.ANDOR, foo, bar));
13501351
verifyResults(Collections.singletonList(5L));
13511352
}
13521353

1353-
@Test
1354+
@Test // GH-3250
13541355
public void testBitOpOneBytes() {
13551356
doReturn(5L).when(nativeConnection).bitOp(BitOperation.ONE, fooBytes, barBytes);
13561357
actual.add(connection.bitOp(BitOperation.ONE, fooBytes, barBytes));
13571358
verifyResults(Collections.singletonList(5L));
13581359
}
13591360

1360-
@Test
1361+
@Test // GH-3250
13611362
public void testBitOpOne() {
13621363
doReturn(5L).when(nativeConnection).bitOp(BitOperation.ONE, fooBytes, barBytes);
13631364
actual.add(connection.bitOp(BitOperation.ONE, foo, bar));

0 commit comments

Comments
 (0)