dry

Rich-Harris · Rich-Harris · commit 69290af1fed1 · 2025-11-04T09:48:30.000-05:00
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -610,9 +610,10 @@ export function get(signal) {
 	} else if (is_derived) {
 		derived = /** @type {Derived} */ (signal);
 
+		var should_reconnect = is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0;
+
 		if (batch_values?.has(derived)) {
-			// TODO DRY out
-			if (is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0) {
+			if (should_reconnect) {
 				reconnect(derived);
 			}
 
@@ -623,7 +624,7 @@ export function get(signal) {
 			update_derived(derived);
 		}
 
-		if (is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0) {
+		if (should_reconnect) {
 			reconnect(derived);
 		}
 	} else if (batch_values?.has(signal)) {

Original file line number	Diff line number	Diff line change
`@@ -610,9 +610,10 @@ export function get(signal) {`
`610`	`610`	`} else if (is_derived) {`
`611`	`611`	`derived = /** @type {Derived} */ (signal);`
`612`	`612`
	`613`	`+ var should_reconnect = is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0;`
	`614`	`+`
`613`	`615`	`if (batch_values?.has(derived)) {`
`614`		`- // TODO DRY out`
`615`		`- if (is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0) {`
	`616`	`+ if (should_reconnect) {`
`616`	`617`	`reconnect(derived);`
`617`	`618`	`}`
`618`	`619`
`@@ -623,7 +624,7 @@ export function get(signal) {`
`623`	`624`	`update_derived(derived);`
`624`	`625`	`}`
`625`	`626`
`626`		`- if (is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0) {`
	`627`	`+ if (should_reconnect) {`
`627`	`628`	`reconnect(derived);`
`628`	`629`	`}`
`629`	`630`	`} else if (batch_values?.has(signal)) {`