Plot live updates over time #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
===========================================
- Coverage 100.00% 94.73% -5.27%
===========================================
Files 3 3
Lines 134 152 +18
===========================================
+ Hits 134 144 +10
- Misses 0 8 +8 ☔ View full report in Codecov by Sentry. |
sylhare
reviewed
Jan 11, 2024
| # Using linux date | ||
| # For mac - brew install coreutils ; echo "alias date=gdate" >> ~/.bash_profile | ||
| runtime="30 minutes" | ||
| runtime="24 hours" |
Owner
There was a problem hiding this comment.
If I were to work on it, I would put some of the value like the runtime or sleep time as variables 🤔
But I don't mind as is.
| self.data_path = data_path | ||
| self.load_data() | ||
|
|
||
| def load_data(self): |
Owner
There was a problem hiding this comment.
so it's separated to be able to load the data asynchronously?
| # Leave more space for the legend | ||
| plt.subplots_adjust(right=0.7) | ||
|
|
||
| def plot_category(self, category, size=(10, 5)): |
Owner
There was a problem hiding this comment.
Would you have an example of how you used the new methods ? (For the Readme)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I'm not necessarily suggesting that this be merged as-is, but I didn't want my changes to be wasted if they might be useful to others.
So this is something I got working for my use case which is analysing long-term memory usage (e.g. over several hours) of a set of containers.
If there are parts of this which you think are useful then I'm happy to split them out / clean them up, or for you to pick and choose.
For comparison, there is some memory graphing in the Docker Desktop UI now, but it is only either per-container, or a total for all containers (rather than all containers on 1 graph) and also in my experience it is not always persistent or reliable (has gaps).
So anyway - if this just sits open as something potentially useful that's fine, or if you're interested in merging some/all then that's great too!