Skip to content

Commit 6002c21

Browse files
author
pipeline
committed
v19.4.53 is released
1 parent 7da3f33 commit 6002c21

File tree

869 files changed

+11983
-4016
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

869 files changed

+11983
-4016
lines changed

‎controls/buttons/CHANGELOG.md‎

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,31 @@
22

33
## [Unreleased]
44

5-
## 19.4.52 (2022-02-15)
5+
## 19.4.53 (2022-02-22)
6+
7+
### Radio Button
8+
9+
#### Bug Fixes
10+
11+
- Issue with accessing the element in the destroy method of radio button has been resolved.
12+
13+
## 19.4.50 (2022-02-08)
14+
15+
### Checkbox
16+
17+
#### Bug Fixes
18+
19+
- Issue with Checkbox value not being posted in form has been resolved.
20+
21+
## 19.4.42 (2022-01-11)
22+
23+
### Checkbox
24+
25+
#### Bug Fixes
26+
27+
- Issue with checkbox in talkback has been resolved.
28+
29+
## 19.4.38 (2021-12-17)
630

731
### Chips
832

‎controls/buttons/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@syncfusion/ej2-buttons",
3-
"version": "18.29.0",
3+
"version": "19.4.52",
44
"description": "A package of feature-rich Essential JS 2 components such as Button, CheckBox, RadioButton and Switch.",
55
"author": "Syncfusion Inc.",
66
"license": "SEE LICENSE IN license",

‎controls/buttons/src/check-box/check-box.ts‎

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export class CheckBox extends Component<HTMLInputElement> implements INotifyProp
4040
private formElement: HTMLElement;
4141
private initialCheckedValue: boolean;
4242
private wrapper: Element;
43+
private clickTriggered: boolean = false;
4344

4445
/**
4546
* Triggers when the CheckBox state has been changed by user interaction.
@@ -195,6 +196,14 @@ export class CheckBox extends Component<HTMLInputElement> implements INotifyProp
195196
}
196197

197198
private clickHandler(event: Event): void {
199+
if ((event.target as HTMLElement).tagName === 'INPUT' && this.clickTriggered) {
200+
event.stopPropagation();
201+
this.clickTriggered = false;
202+
return;
203+
}
204+
if ((event.target as HTMLElement).tagName === 'SPAN' || (event.target as HTMLElement).tagName === 'LABEL') {
205+
this.clickTriggered = true;
206+
}
198207
if (this.isMouseClick) {
199208
this.focusOutHandler();
200209
this.isMouseClick = false;
@@ -461,7 +470,6 @@ export class CheckBox extends Component<HTMLInputElement> implements INotifyProp
461470
*/
462471
protected preRender(): void {
463472
let element: HTMLInputElement = this.element;
464-
this.formElement = <HTMLFormElement>closest(this.element, 'form');
465473
this.tagName = this.element.tagName;
466474
element = wrapperInitialize(this.createElement, 'EJS-CHECKBOX', 'checkbox', element, WRAPPER, 'checkbox');
467475
this.element = element;
@@ -529,15 +537,16 @@ export class CheckBox extends Component<HTMLInputElement> implements INotifyProp
529537

530538
protected unWireEvents(): void {
531539
const wrapper: Element = this.wrapper;
532-
EventHandler.remove(this.element, 'click', this.clickHandler);
540+
EventHandler.remove(wrapper, 'click', this.clickHandler);
533541
EventHandler.remove(this.element, 'keyup', this.keyUpHandler);
534542
EventHandler.remove(this.element, 'focus', this.focusHandler);
535543
EventHandler.remove(this.element, 'focusout', this.focusOutHandler);
536544
const label: Element = wrapper.getElementsByTagName('label')[0];
537545
EventHandler.remove(label, 'mousedown', this.labelMouseDownHandler);
538546
EventHandler.remove(label, 'mouseup', this.labelMouseUpHandler);
539-
if (this.formElement) {
540-
EventHandler.remove(this.formElement, 'reset', this.formResetHandler);
547+
const formElem: HTMLFormElement = <HTMLFormElement>closest(this.element, 'form');
548+
if (formElem) {
549+
EventHandler.remove(formElem, 'reset', this.formResetHandler);
541550
}
542551
if (this.tagName === 'EJS-CHECKBOX') {
543552
EventHandler.remove(this.element, 'change', this.changeHandler);
@@ -547,15 +556,16 @@ export class CheckBox extends Component<HTMLInputElement> implements INotifyProp
547556

548557
protected wireEvents(): void {
549558
const wrapper: Element = this.getWrapper();
550-
EventHandler.add(this.element, 'click', this.clickHandler, this);
559+
EventHandler.add(wrapper, 'click', this.clickHandler, this);
551560
EventHandler.add(this.element, 'keyup', this.keyUpHandler, this);
552561
EventHandler.add(this.element, 'focus', this.focusHandler, this);
553562
EventHandler.add(this.element, 'focusout', this.focusOutHandler, this);
554563
const label: Element = wrapper.getElementsByTagName('label')[0];
555564
EventHandler.add(label, 'mousedown', this.labelMouseDownHandler, this);
556565
EventHandler.add(label, 'mouseup', this.labelMouseUpHandler, this);
557-
if (this.formElement) {
558-
EventHandler.add(this.formElement, 'reset', this.formResetHandler, this);
566+
const formElem: HTMLFormElement = <HTMLFormElement>closest(this.element, 'form');
567+
if (formElem) {
568+
EventHandler.add(formElem, 'reset', this.formResetHandler, this);
559569
}
560570
if (this.tagName === 'EJS-CHECKBOX') {
561571
EventHandler.add(this.element, 'change', this.changeHandler, this);

‎controls/buttons/src/radio-button/radio-button.ts‎

Lines changed: 23 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ export class RadioButton extends Component<HTMLInputElement> implements INotifyP
3333
private initialCheckedValue: boolean;
3434
private angularValue: string;
3535
private isVue: boolean;
36+
private wrapper: Element;
3637

3738
/**
3839
* Event trigger when the RadioButton state has been changed by user interaction.
@@ -170,25 +171,27 @@ export class RadioButton extends Component<HTMLInputElement> implements INotifyP
170171
* @returns {void}
171172
*/
172173
public destroy(): void {
173-
const radioWrap: Element = this.element.parentElement;
174+
const radioWrap: Element = this.wrapper;
174175
super.destroy();
175-
if (!this.disabled) {
176-
this.unWireEvents();
177-
}
178-
if (this.tagName === 'INPUT') {
179-
if (radioWrap.parentNode) {
180-
radioWrap.parentNode.insertBefore(this.element, radioWrap);
176+
if (radioWrap) {
177+
if (!this.disabled) {
178+
this.unWireEvents();
179+
}
180+
if (this.tagName === 'INPUT') {
181+
if (radioWrap.parentNode) {
182+
radioWrap.parentNode.insertBefore(this.element, radioWrap);
183+
}
184+
detach(radioWrap);
185+
this.element.checked = false;
186+
['name', 'value', 'disabled'].forEach((key: string) => {
187+
this.element.removeAttribute(key);
188+
});
189+
} else {
190+
['role', 'aria-checked', 'class'].forEach((key: string) => {
191+
radioWrap.removeAttribute(key);
192+
});
193+
radioWrap.innerHTML = '';
181194
}
182-
detach(radioWrap);
183-
this.element.checked = false;
184-
['name', 'value', 'disabled'].forEach((key: string) => {
185-
this.element.removeAttribute(key);
186-
});
187-
} else {
188-
['role', 'aria-checked', 'class'].forEach((key: string) => {
189-
radioWrap.removeAttribute(key);
190-
});
191-
radioWrap.innerHTML = '';
192195
}
193196
}
194197

@@ -429,6 +432,7 @@ export class RadioButton extends Component<HTMLInputElement> implements INotifyP
429432
this.wireEvents();
430433
}
431434
this.renderComplete();
435+
this.wrapper = this.getWrapper();
432436
}
433437

434438
private setDisabled(): void {
@@ -470,12 +474,12 @@ export class RadioButton extends Component<HTMLInputElement> implements INotifyP
470474
}
471475

472476
protected unWireEvents(): void {
473-
const label: Element = this.getLabel();
477+
const label: Element = this.wrapper;
474478
EventHandler.remove(this.element, 'change', this.changeHandler);
475479
EventHandler.remove(this.element, 'focus', this.focusHandler);
476480
EventHandler.remove(this.element, 'focusout', this.focusOutHandler);
477481
EventHandler.remove(this.element, 'keyup', this.keyUpHandler);
478-
const rippleLabel: Element = label.getElementsByClassName(LABEL)[0];
482+
const rippleLabel: Element = label.getElementsByTagName('label')[0];
479483
if (rippleLabel) {
480484
EventHandler.remove(rippleLabel, 'mousedown', this.labelRippleHandler);
481485
EventHandler.remove(rippleLabel, 'mouseup', this.labelRippleHandler);

‎controls/buttons/styles/button/_bootstrap5-definition.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//layout variables
22
$btn-font-size: $text-sm !default;
33
$btn-border: 1px solid !default;
4-
$btn-icon-margin-top: -4px !default;
4+
$btn-icon-margin-top: -2px !default;
55
$btn-icon-btn-width: 1em !default;
66
$btn-icon-top-bottom-padding: 8px !default;
77
$btn-icon-small-width: 1em !default;

‎controls/buttons/styles/button/_tailwind-definition.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//layout variables
22
$btn-font-size: $text-sm !default;
33
$btn-border: 1px solid !default;
4-
$btn-icon-margin-top: -2px !default;
4+
$btn-icon-margin-top: 0 !default;
55
$btn-icon-btn-width: 1em !default;
66
$btn-icon-top-bottom-padding: 8px !default;
77
$btn-icon-small-width: 1em !default;

‎controls/buttons/styles/check-box/_bootstrap5-definition.scss‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ $cbox-bigger-check-fontsize: 10px !default;
33
$cbox-bigger-font-size: 16px !default;
44
$cbox-bigger-height: 16px !default;
55
$cbox-bigger-indeterminate-fontsize: 10px !default;
6-
$cbox-bigger-indeterminate-lineheight: 16px !default;
7-
$cbox-bigger-lineheight: 16px !default;
6+
$cbox-bigger-indeterminate-lineheight: 14px !default;
7+
$cbox-bigger-lineheight: 14px !default;
88
$cbox-bigger-margin: 10px !default;
99
$cbox-bigger-small-check-fontsize: 10px !default;
1010
$cbox-bigger-small-font-size: 15px !default;

‎controls/buttons/styles/chips/_bootstrap-dark-definition.scss‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ $chip-avatar-margin: 0 8px 0 -10px !default;
7979
$chip-avatar-content-font-size: 13px !default;
8080
$chip-leading-icon-font-size: 14px !default;
8181
$chip-leading-icon-size: 20px !default;
82-
$chip-leading-icon-margin: 0 8px 0 -6px !default;
82+
$chip-leading-icon-margin: 0 4px 0 -6px !default;
8383
$chip-multiselection-icon-margin-top: 0 !default;
8484
$chip-delete-icon-font-size: 10px !default;
8585
$chip-delete-icon-size: 14px !default;
@@ -100,15 +100,15 @@ $chip-touch-avatar-margin: 0 8px 0 -12px !default;
100100
$chip-touch-avatar-content-font-size: 15px !default;
101101
$chip-touch-leading-icon-font-size: 16px !default;
102102
$chip-touch-leading-icon-size: 24px !default;
103-
$chip-touch-leading-icon-margin: 0 8px 0 -8px !default;
103+
$chip-touch-leading-icon-margin: 0 4px 0 -8px !default;
104104
$chip-touch-delete-icon-font-size: 10px !default;
105105
$chip-touch-delete-icon-size: 18px !default;
106106
$chip-touch-delete-icon-margin: 0 -4px 0 8px !default;
107107
//Touch-RTL
108108
$chip-touch-rtl-avatar-wrapper-border-radius: 4px 16px 16px 4px !default;
109109
$chip-touch-rtl-avatar-margin: 0 -12px 0 8px !default;
110110
$chip-touch-rtl-leading-icon-margin: 0 -8px 0 8px !default;
111-
$chip-touch-rtl-delete-icon-margin: 0 8px 0 -4px !default;
111+
$chip-touch-rtl-delete-icon-margin: 0 4px 0 -4px !default;
112112
//outline
113113
$chip-outline-hover-bg-color: $grey !default;
114114
$chip-outline-focus-bg-color: $grey-dark !default;

‎controls/buttons/styles/chips/_bootstrap-definition.scss‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ $chip-avatar-margin: 0 8px 0 -10px !default;
7979
$chip-avatar-content-font-size: 13px !default;
8080
$chip-leading-icon-font-size: 14px !default;
8181
$chip-leading-icon-size: 20px !default;
82-
$chip-leading-icon-margin: 0 8px 0 -6px !default;
82+
$chip-leading-icon-margin: 0 4px 0 -6px !default;
8383
$chip-multiselection-icon-margin-top: 0 !default;
8484
$chip-delete-icon-font-size: 10px !default;
8585
$chip-delete-icon-size: 14px !default;
@@ -100,15 +100,15 @@ $chip-touch-avatar-margin: 0 8px 0 -12px !default;
100100
$chip-touch-avatar-content-font-size: 15px !default;
101101
$chip-touch-leading-icon-font-size: 16px !default;
102102
$chip-touch-leading-icon-size: 24px !default;
103-
$chip-touch-leading-icon-margin: 0 8px 0 -8px !default;
103+
$chip-touch-leading-icon-margin: 0 4px 0 -8px !default;
104104
$chip-touch-delete-icon-font-size: 10px !default;
105105
$chip-touch-delete-icon-size: 18px !default;
106106
$chip-touch-delete-icon-margin: 0 -4px 0 8px !default;
107107
//Touch-RTL
108108
$chip-touch-rtl-avatar-wrapper-border-radius: 4px 16px 16px 4px !default;
109109
$chip-touch-rtl-avatar-margin: 0 -12px 0 8px !default;
110110
$chip-touch-rtl-leading-icon-margin: 0 -8px 0 8px !default;
111-
$chip-touch-rtl-delete-icon-margin: 0 8px 0 -4px !default;
111+
$chip-touch-rtl-delete-icon-margin: 0 4px 0 -4px !default;
112112
//outline
113113
$chip-outline-hover-bg-color: $grey-e6 !default;
114114
$chip-outline-focus-bg-color: $grey-dd !default;

‎controls/buttons/styles/chips/_bootstrap4-definition.scss‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ $chip-avatar-margin: 0 8px 0 -10px !default;
8484
$chip-avatar-content-font-size: 10px !default;
8585
$chip-leading-icon-font-size: 14px !default;
8686
$chip-leading-icon-size: 18px !default;
87-
$chip-leading-icon-margin: 0 8px 0 -6px !default;
87+
$chip-leading-icon-margin: 0 4px 0 -6px !default;
8888
$chip-multiselection-icon-margin-top: 2px !default;
8989
$chip-delete-icon-font-size: 8px !default;
9090
$chip-delete-icon-size: 14px !default;
@@ -105,15 +105,15 @@ $chip-touch-avatar-margin: -2px 8px 0 -12px !default;
105105
$chip-touch-avatar-content-font-size: 15px !default;
106106
$chip-touch-leading-icon-font-size: 16px !default;
107107
$chip-touch-leading-icon-size: 24px !default;
108-
$chip-touch-leading-icon-margin: -2px 8px 0 -8px !default;
108+
$chip-touch-leading-icon-margin: -2px 4px 0 -8px !default;
109109
$chip-touch-delete-icon-font-size: 10px !default;
110110
$chip-touch-delete-icon-size: 18px !default;
111111
$chip-touch-delete-icon-margin: 0 -4px 0 8px !default;
112112
//Touch-RTL
113113
$chip-touch-rtl-avatar-wrapper-border-radius: 4px 16px 16px 4px !default;
114114
$chip-touch-rtl-avatar-margin: 0 -12px 0 8px !default;
115115
$chip-touch-rtl-leading-icon-margin: 0 -8px 0 8px !default;
116-
$chip-touch-rtl-delete-icon-margin: 0 8px 0 -4px !default;
116+
$chip-touch-rtl-delete-icon-margin: 0 4px 0 -4px !default;
117117
//outline
118118
$chip-outline-hover-bg-color: $gray-600 !default;
119119
$chip-outline-focus-bg-color: transparent !default;

0 commit comments

Comments
 (0)