typescript

Author: daveads

.github/workflows/bench.yml

@@ -41,7 +41,13 @@ jobs:
           imageName: graphql-benchmarks
           push: never
           runCmd: |
-            bash ./graphql/${{ matrix.service }}/setup.sh
+
+            bash ./graphql/${{ matrix.service }}/setup.sha
+
+            npm install
+            sudo npm install -g typescript
+
+            tsc run_benchmarks.tx
             node run_benchmarks.js ${{ matrix.service }}
 
       - name: List benchmark files

run_benchmarks.js renamed to run_benchmarks.ts

@@ -1,38 +1,37 @@
-const { exec, execSync } = require('child_process');
-const fs = require('fs');
-const path = require('path');
-const util = require('util');
+import { exec, execSync } from 'child_process';
+import * as fs from 'fs';
+import * as path from 'path';
+import * as util from 'util';
 
 const execAsync = util.promisify(exec);
 
 // Start services and run benchmarks
-function killServerOnPort(port) {
+function killServerOnPort(port: number): void {
   try {
-    const pid = execSync(`lsof -t -i:${port}`).toString().trim();
+    const pid: string = execSync(`lsof -t -i:${port}`).toString().trim();
     if (pid) {
       execSync(`kill ${pid}`);
       console.log(`Killed process running on port ${port}`);
     } else {
       console.log(`No process found running on port ${port}`);
     }
   } catch (error) {
-    console.error(`Error killing server on port ${port}:`, error.message);
+    console.error(`Error killing server on port ${port}:`, (error as Error).message);
   }
 }
 
-const bench1Results = [];
-const bench2Results = [];
-const bench3Results = [];
+const bench1Results: string[] = [];
+const bench2Results: string[] = [];
+const bench3Results: string[] = [];
 
 killServerOnPort(3000);
 execSync('sh nginx/run.sh');
 
-async function runBenchmarkAsync(serviceScript, bench) {
+async function runBenchmarkAsync(serviceScript: string, bench: number): Promise<void> {
   let graphqlEndpoint = 'http://localhost:8000/graphql';
   if (serviceScript.includes('hasura')) {
     graphqlEndpoint = 'http://127.0.0.1:8080/v1/graphql';
   }
-
   const benchmarkScript = 'wrk/bench.sh';
   const sanitizedServiceScriptName = serviceScript.replace(/\//g, '_');
   const resultFiles = [
@@ -54,7 +53,6 @@ async function runBenchmarkAsync(serviceScript, bench) {
     console.log(`Running benchmark ${bench} for ${serviceScript}`);
     const outputFile = `bench${bench}_${resultFile}`;
     await execAsync(`bash ${benchmarkScript} ${graphqlEndpoint} ${bench} > ${outputFile}`);
-    
     if (bench === 1) {
       bench1Results.push(outputFile);
     } else if (bench === 2) {
@@ -65,21 +63,18 @@ async function runBenchmarkAsync(serviceScript, bench) {
   }
 }
 
-async function runBenchmark(serviceScript) {
+async function runBenchmark(serviceScript: string): Promise<void> {
   killServerOnPort(8000);
   execSync('sleep 5');
-
   if (serviceScript.includes('hasura')) {
     execSync(`bash ${serviceScript}`, { stdio: 'inherit' });
   } else {
     execSync(`bash ${serviceScript} &`, { stdio: 'inherit' });
   }
-
   execSync('sleep 15');
 
   const benchmarks = [1, 2, 3];
-  const benchmarkPromises = benchmarks.map(bench => runBenchmarkAsync(serviceScript, bench));
-
+  const benchmarkPromises: Promise<void>[] = benchmarks.map(bench => runBenchmarkAsync(serviceScript, bench));
   await Promise.all(benchmarkPromises);
 }
 
@@ -90,8 +85,8 @@ if (process.argv.length < 3) {
   process.exit(1);
 }
 
-const service = process.argv[2];
-const validServices = ['apollo_server', 'caliban', 'netflix_dgs', 'gqlgen', 'tailcall', 'async_graphql', 'hasura', 'graphql_jit'];
+const service: string = process.argv[2];
+const validServices: string[] = ['apollo_server', 'caliban', 'netflix_dgs', 'gqlgen', 'tailcall', 'async_graphql', 'hasura', 'graphql_jit'];
 
 if (!validServices.includes(service)) {
   console.log(`Invalid service name. Available services: ${validServices.join(', ')}`);
@@ -102,9 +97,8 @@ if (fs.existsSync('results.md')) {
   fs.unlinkSync('results.md');
 }
 
-async function main() {
+async function main(): Promise<void> {
   await runBenchmark(`graphql/${service}/run.sh`);
-
   if (service === 'apollo_server') {
     process.chdir('graphql/apollo_server');
     execSync('npm stop');
@@ -114,7 +108,7 @@ async function main() {
   }
 }
 
-main().catch(error => {
+main().catch((error: Error) => {
   console.error("An error occurred:", error);
   process.exit(1);
-});
+});