Skip to content

Bug #190387 fix: page limit is not working on notifications list view #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-3.0.4
Choose a base branch
from
Open

Bug #190387 fix: page limit is not working on notifications list view #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/com_tjnotifications/admin/models/notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,15 @@ protected function populateState($ordering = 'id', $direction = 'asc')
parent::populateState($ordering, $direction);

// Get pagination request variables
$limit = $app->getUserStateFromRequest($this->context . '.list.limit', 'limit', $app->get('list_limit'), 'int');
$limit = (isset($app->input->get('list')['limit'])) ? $app->input->get('list')['limit'] : $app->getUserStateFromRequest('global.list.limit', 'limit', $app->get('list_limit'), 'int');
Copy link
Contributor

@ankush-maherwal ankush-maherwal Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepa-g In $app->input->get('list')['limit'] the $app->input->get('list') should have some default value and the filter or else it will give error if list is not defined same for $app->get('list_limit')


$limitstart = $app->input->get('limitstart', 0, 'int');

// In case limit has been changed, adjust it
$limitstart = ($limit !== 0 ? (floor($limitstart / $limit) * $limit) : 0);
if ($limitstart != 0)
{
// In case limit has been changed, adjust it
$limitstart = ($limit !== 0 ? (floor($limitstart / $limit) * $limit) : 0);
}

$this->setState('list.limit', $limit);
$this->setState('list.start', $limitstart);
Expand Down