Skip to content

Conversation

@yashmjain
Copy link

The pre-requisite note "Note: All tests require a valid OpenAI/Anthropic API key set in the environment variables." was originally placed after the Python test command. However, it should be presented beforehand so that users can configure the required environment variables prior to executing the tests.

@yashmjain yashmjain changed the title Move pre-requisite note to the start of the Python Tests command docs: Move pre-requisite note to the start of the Python Tests command Sep 18, 2025
@yashmjain yashmjain changed the title docs: Move pre-requisite note to the start of the Python Tests command docs: move pre-requisite note to the start of the python tests command Sep 18, 2025
Copy link
Contributor

@YoungVor YoungVor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Yash for contributing to Fenic! Looks good, after one minor change

@bcallender bcallender added the 0.5.0 PRs to be merged for the 0.5.0 release label Sep 24, 2025
@YoungVor YoungVor self-requested a review September 25, 2025 00:18
Copy link
Contributor

@YoungVor YoungVor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yashmjain , thank you for the contribution! Before making a commit, could you set up authentication signing? You can follow the instructions here: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@YoungVor YoungVor removed the 0.5.0 PRs to be merged for the 0.5.0 release label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants