Refactor parseWord() into parseWordByHyphenation() and parseWordByPatterns()

Author: alexander-nitsche

src/Syllable.php

@@ -748,33 +748,48 @@ private function parseWord($word)
     {
         $wordLength = mb_strlen($word);
 
-        // Is this word smaller than the minimal length requirement?
         if ($wordLength < $this->minHyphenLeft + $this->minHyphenRight
             || $wordLength < $this->minWordLength) {
             return [$word];
         }
 
         $wordLowerCased = mb_strtolower($word);
 
-        // Is it a pre-hyphenated word?
         if (isset($this->hyphenation[$wordLowerCased])) {
-            $hyphenation = $this->hyphenation[$wordLowerCased];
-            $hyphenationLength = mb_strlen($hyphenation);
-            $parts = [];
-            $part = '';
-            for ($i = 0, $j = 0; $i < $hyphenationLength; $i++) {
-                if (mb_substr($hyphenation, $i, 1) !== '-') {
-                    $part .= mb_substr($word, $j++, 1);
-                } else {
-                    $parts[] = $part;
-                    $part = '';
-                }
-            }
-            if (!empty($part)) {
+            return $this->parseWordByHyphenation($word, $wordLowerCased);
+        } else {
+            return $this->parseWordByPatterns($word, $wordLength, $wordLowerCased);
+        }
+    }
+
+    private function parseWordByHyphenation($word, $wordLowerCased = null)
+    {
+        $wordLowerCased = $wordLowerCased ?: mb_strtolower($word);
+
+        $hyphenation = $this->hyphenation[$wordLowerCased];
+        $hyphenationLength = mb_strlen($hyphenation);
+
+        $parts = [];
+        $part = '';
+        for ($i = 0, $j = 0; $i < $hyphenationLength; $i++) {
+            if (mb_substr($hyphenation, $i, 1) !== '-') {
+                $part .= mb_substr($word, $j++, 1);
+            } else {
                 $parts[] = $part;
+                $part = '';
             }
-            return $parts;
         }
+        if (!empty($part)) {
+            $parts[] = $part;
+        }
+
+        return $parts;
+    }
+
+    private function parseWordByPatterns($word, $wordLength = 0, $wordLowerCased = null)
+    {
+        $wordLength = $wordLength > 0 ? $wordLength : mb_strlen($word);
+        $wordLowerCased = $wordLowerCased ?: mb_strtolower($word);
 
         // Convenience array
         $text = '.'.$wordLowerCased.'.';