Skip to content

Conversation

@erh
Copy link
Member

@erh erh commented Nov 9, 2025

No description provided.

@erh erh requested a review from dgottlieb November 9, 2025 20:03
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 9, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 10, 2025
if solvingState.shouldStopEarly() {
cancel()
break solutionLoop
// we don't exit the loop to get the last solutions so we don't waste them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the "add live IK solutions to cbirrt" -- I'm assuming we'll want to add the break back in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe. will have to see how the mechanics works

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 10, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 10, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 10, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 10, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 10, 2025
@github-actions
Copy link
Contributor

Availability

Scene # viamrobotics:main erh:20251109-ik-diag Percent Improvement Health
1 100% 100% 0%
2 100% 100% 0%
3 100% 100% 0%
4 100% 100% 0%
5 100% 100% 0%
6 90% 100% 11%
7 100% 100% 0%
8 100% 100% 0%
9 100% 100% 0%
10 100% 100% 0%

Quality

Scene # viamrobotics:main erh:20251109-ik-diag Percent Improvement Probability of Improvement Health
1 1.31±0.00 1.31±0.00 0% 51%
2 0.90±0.00 0.90±0.00 -0% 50%
3 6.52±0.64 5.85±1.25 10% 68%
4 3.23±0.41 3.23±0.41 -0% 50%
5 7.87±1.75 10.76±3.73 -37% 24%
6 8.46±2.14 9.15±3.21 -8% 43%
7 5.85±2.79 5.85±2.79 -0% 50%
8 0.90±0.00 0.90±0.00 -0% 50%
9 4.20±0.14 4.29±0.21 -2% 36%
10 12.84±0.41 12.84±0.41 -0% 50%

Performance

Scene # viamrobotics:main erh:20251109-ik-diag Percent Improvement Probability of Improvement Health
1 0.02±0.00 0.02±0.00 -0% 50%
2 0.06±0.01 0.06±0.01 6% 63%
3 0.08±0.02 0.08±0.06 -5% 47%
4 1.27±0.08 1.27±0.07 -1% 48%
5 1.64±0.37 3.15±3.59 -92% 34%
6 1.88±0.40 2.11±0.67 -13% 38%
7 2.42±0.72 2.51±0.77 -4% 47%
8 0.05±0.01 0.06±0.01 -12% 26%
9 2.53±0.21 2.18±0.17 14% 91%
10 6.48±1.07 6.46±1.05 0% 50%

The above data was generated by running scenes defined in the motion-testing repository
The SHA1 for viamrobotics:main is: 5385bdb0a6d8e617a53c351316b62a26a2b93ad4
The SHA1 for erh:20251109-ik-diag is: 5385bdb0a6d8e617a53c351316b62a26a2b93ad4

  • 10 samples were taken for each scene

@erh erh merged commit 3ed7f75 into viamrobotics:main Nov 10, 2025
33 of 35 checks passed
@erh erh deleted the 20251109-ik-diag branch November 10, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants