RSDK-12154 RSDK-12155 Audio component wrappers #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviamiller
changed the title
oliviamiller
commented
Oct 27, 2025
| @@ -1,4 +1,4 @@ | |||
| import '../../gen/common/v1/common.pb.dart'; | |||
| import '../../gen/common/v1/common.pb.dart' as common_pb; | |||
Member
Author
There was a problem hiding this comment.
Had to alias common_pb in these files due to GetProperties causing naming conflicts
njooma
requested changes
Nov 4, 2025
Member
njooma
left a comment
njooma
left a comment
There was a problem hiding this comment.
Please pull from main to get the latest changes! lots of them are actually identical to the ones you made for common_pb
njooma
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new AudioIn and AudioOut component types. Protos to be merged: #431