Skip to content

fix topic.partition.committed_end_to_end_lag_milliseconds_max metric LOGBROKER-10068 #28527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2025
Merged

fix topic.partition.committed_end_to_end_lag_milliseconds_max metric LOGBROKER-10068 #28527

merged 2 commits into from
Nov 11, 2025
+25 −11

Conversation

@ubyte
Copy link
Collaborator

@ubyte ubyte commented Nov 10, 2025

…

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

LOGBROKER-10068

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

🟢 2025-11-10 12:54:32 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 12:56:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 55025b6 has started.
⚪ 2025-11-10 12:56:27 UTC Artifacts will be uploaded here
⚪ 2025-11-10 12:58:07 UTC ya make is running...
⚫ 2025-11-10 14:06:01 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 12:56:38 UTC Pre-commit check linux-x86_64-release-asan for 55025b6 has started.
⚪ 2025-11-10 12:56:42 UTC Artifacts will be uploaded here
⚪ 2025-11-10 12:58:19 UTC ya make is running...
⚫ 2025-11-10 14:06:00 UTC Check cancelled

@ubyte ubyte force-pushed the committed_end_to_end_lag_milliseconds_max-LOGBROKER-10068 branch from a45444d to dd69e6e Compare November 10, 2025 14:05
@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 14:08:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c6740c has started.
⚪ 2025-11-10 14:08:57 UTC Artifacts will be uploaded here
⚪ 2025-11-10 14:11:16 UTC ya make is running...
🟡 2025-11-10 15:54:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31607 30202 0 1 1385 19

⚪ 2025-11-10 15:54:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-10 16:02:53 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37 (only retried tests) 22 0 0 0 15

🟢 2025-11-10 16:03:04 UTC Build successful.
🟢 2025-11-10 16:03:25 UTC ydbd size 2.3 GiB changed* by +22.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 197fc79 merge: 5c6740c diff diff %
ydbd size 2 437 406 376 Bytes 2 437 429 840 Bytes +22.9 KiB +0.001%
ydbd stripped size 518 590 928 Bytes 518 598 864 Bytes +7.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 14:09:43 UTC Pre-commit check linux-x86_64-release-asan for 5c6740c has started.
⚪ 2025-11-10 14:10:01 UTC Artifacts will be uploaded here
⚪ 2025-11-10 14:12:13 UTC ya make is running...
🟡 2025-11-10 16:22:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15467 14961 0 236 247 23

🟢 2025-11-10 16:23:13 UTC Build successful.
🟢 2025-11-10 16:23:40 UTC ydbd size 3.8 GiB changed* by +35.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 197fc79 merge: 5c6740c diff diff %
ydbd size 4 080 450 064 Bytes 4 080 486 832 Bytes +35.9 KiB +0.001%
ydbd stripped size 1 514 704 840 Bytes 1 514 715 816 Bytes +10.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Nov 11, 2025
View reviewed changes
@ubyte ubyte marked this pull request as ready for review November 11, 2025 07:55
@ubyte ubyte requested a review from a team as a code owner November 11, 2025 07:55
@ubyte ubyte requested review from Copilot and nshestakov November 11, 2025 07:55
Copilot finished reviewing on behalf of ubyte November 11, 2025 07:59
Copilot AI reviewed Nov 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the topic.partition.committed_end_to_end_lag_milliseconds_max metric calculation by ensuring that actual timestamps from user info are used when available instead of estimated timestamps. This addresses issue LOGBROKER-10068.

Key changes:

  • Added logic to use actual timestamps (userInfo.CreateTimestamp and userInfo.WriteTimestamp) when ActualTimestamps flag is true in the CreateSnapshot function
  • Updated test to validate the corrected committed time lag calculation with proper message sequence and verification
  • Changed seqNo value from 11 to 10 to match the maxSeqNo constraint

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ydb/core/persqueue/pqtablet/partition/partition.cpp Added conditional branch to use actual timestamps when available for calculating committed message lag, and changed snapshot variables from auto to const auto
ydb/core/persqueue/ut/ut_with_sdk/topic_ut.cpp Updated test to verify the fixed metric with corrected sequence number, proper message verification queue, and updated expected committed time lag values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nshestakov
nshestakov previously approved these changes Nov 11, 2025
View reviewed changes
@ubyte
Update ydb/core/persqueue/ut/ut_with_sdk/topic_ut.cpp
180aa96 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ubyte ubyte dismissed stale reviews from nshestakov and alexnick88 via 180aa96 November 11, 2025 08:34
@ubyte ubyte enabled auto-merge (squash) November 11, 2025 08:35
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 08:37:34 UTC Pre-commit check linux-x86_64-release-asan for 319f497 has started.
⚪ 2025-11-11 08:37:51 UTC Artifacts will be uploaded here
⚪ 2025-11-11 08:39:58 UTC ya make is running...
🟡 2025-11-11 11:20:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15213 14741 0 168 280 24

🟢 2025-11-11 11:20:25 UTC Build successful.
🟢 2025-11-11 11:20:51 UTC ydbd size 3.8 GiB changed* by +288 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0e72d0f merge: 319f497 diff diff %
ydbd size 4 081 237 048 Bytes 4 081 237 336 Bytes +288 Bytes +0.000%
ydbd stripped size 1 515 018 120 Bytes 1 515 018 248 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 11:35:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 319f497 has started.
⚫ 2025-11-11 11:36:05 UTC Check cancelled

This was referenced Nov 11, 2025
Merged
Merged
@iddqdex iddqdex added the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 11:37:02 UTC Pre-commit check linux-x86_64-release-asan for 8446096 has started.
⚪ 2025-11-11 11:37:15 UTC Artifacts will be uploaded here
⚪ 2025-11-11 11:38:38 UTC ya make is running...
🟡 2025-11-11 13:41:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15213 14686 0 201 297 29

🟢 2025-11-11 13:41:59 UTC Build successful.
🟢 2025-11-11 13:42:31 UTC ydbd size 3.8 GiB changed* by +288 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 531f527 merge: 8446096 diff diff %
ydbd size 4 081 237 048 Bytes 4 081 237 336 Bytes +288 Bytes +0.000%
ydbd stripped size 1 515 018 120 Bytes 1 515 018 248 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 11:37:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8446096 has started.
⚪ 2025-11-11 11:38:05 UTC Artifacts will be uploaded here
⚪ 2025-11-11 11:40:10 UTC ya make is running...
🟡 2025-11-11 12:56:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30913 29502 0 3 1385 23

⚪ 2025-11-11 12:57:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-11 13:18:30 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6915 (only retried tests) 5512 0 0 1383 20

🟢 2025-11-11 13:18:38 UTC Build successful.
🟢 2025-11-11 13:18:59 UTC ydbd size 2.3 GiB changed* by +96 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 531f527 merge: 8446096 diff diff %
ydbd size 2 437 870 168 Bytes 2 437 870 264 Bytes +96 Bytes +0.000%
ydbd stripped size 518 656 528 Bytes 518 656 528 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ubyte ubyte merged commit 8a4d64c into ydb-platform:main Nov 11, 2025
16 of 19 checks passed
@ubyte ubyte deleted the committed_end_to_end_lag_milliseconds_max-LOGBROKER-10068 branch November 11, 2025 13:42
This was referenced Nov 12, 2025
Merged
Merged
ubyte added a commit to ubyte/ydb that referenced this pull request Nov 12, 2025
@ubyte
fix topic.partition.committed_end_to_end_lag_milliseconds_max metric …
bf856b6 
…LOGBROKER-10068 (ydb-platform#28527)
@ubyte ubyte mentioned this pull request Nov 12, 2025
Merged
ubyte added a commit to ubyte/ydb that referenced this pull request Nov 12, 2025
@ubyte
fix topic.partition.committed_end_to_end_lag_milliseconds_max metric …
8cbfa49 
…LOGBROKER-10068 (ydb-platform#28527)
@ubyte ubyte mentioned this pull request Nov 12, 2025
Merged
ubyte added a commit to ubyte/ydb that referenced this pull request Nov 12, 2025
@ubyte
fix topic.partition.committed_end_to_end_lag_milliseconds_max metric …
4a8ea77 
…LOGBROKER-10068 (ydb-platform#28527)
ubyte added a commit that referenced this pull request Nov 12, 2025
@ubyte
fix topic.partition.committed_end_to_end_lag_milliseconds_max metric …
0245a57 
…LOGBROKER-10068 (#28527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@nshestakov nshestakov nshestakov approved these changes

@alexnick88 alexnick88 alexnick88 left review comments

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ubyte @nshestakov @alexnick88 @iddqdex