-
Notifications
You must be signed in to change notification settings - Fork 726
hotfix for healthcheck access rights check #28581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🟢 |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes access check restrictions for the healthcheck endpoint that were introduced in #22513. The main purpose is to allow Prometheus metrics collection without requiring authentication while maintaining access checks for other types of requests.
Key changes:
- Moved authentication check from the HTTP handler registration to inside the healthcheck handler
- Added conditional access check that bypasses authentication for Prometheus format requests
- Refactored code to use base class members (Params, Timeout, JsonSettings, Proto2JsonConfig) instead of local/duplicate variables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/core/viewer/viewer.cpp | Disabled auth at handler registration level with comment indicating auth is now checked inside the handler |
| ydb/core/viewer/viewer_healthcheck.h | Removed duplicate member variables, added conditional access check for non-Prometheus requests, refactored to use base class functionality for parameter parsing and JSON configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog entry
fixes access check restrictions, introduced in #22513
allows for prometheus metrics to be collected without access check.
closes #28021
Changelog category
Description for reviewers
...