Reauth SDK when desktop app is locked #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We convert it into a class so that we can add functionality around invocation that requires overwriting the client id.
This will be needed when trying to reinitialize the client if the desktop app gets locked.
When the desktop session is expired when performing an invocation, we try to reinitialize the client and then retry the invocation.
edif2008
force-pushed
the
eddy/reauth-sdk-when-app-locked
branch
from
e2adbb9 to
dde9add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR adjust the behavior of the SDK in the following scenario:
A program running the SDK initializes a new client that authenticates via the Desktop app. After the client is initialized, the Desktop app gets locked. User will be re-prompted to authorize the SDK. However, after the confirmation, any operation will now fail since the session no longer exists.
🤔 Thought process
Currently, the approach is to catch the new error thrown by the SDK in this scenario:
DesktopSessionExpired. If received, the client will do the following: