Skip to content

Conversation

@morgolock
Copy link
Contributor

Change-Id: I976e01b9be9ee91f7de09f050392576133d1e929

Copy link
Contributor

@gunes-arm gunes-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commit type should be test, but I guess I have a better suggestion. Isn't this a refactor?

@gunes-arm
Copy link
Contributor

gunes-arm commented Oct 17, 2025

Can you also count the number of tests before & after this patch as a sanity check, and report?

@morgolock morgolock force-pushed the pr/flatten_nested_combine branch 2 times, most recently from 6d555eb to 308671f Compare October 20, 2025 08:51
@morgolock
Copy link
Contributor Author

I think the commit type should be test, but I guess I have a better suggestion. Isn't this a refactor?

I changed the commit to

refactor: flatten nested combine usage in NEON validation

@morgolock
Copy link
Contributor Author

Can you also count the number of tests before & after this patch as a sanity check, and report?

With this patch --mode=precommit

Executed 78213 test(s) (78213 passed, 0 expected failures, 0 failed, 0 crashed, 0 disabled) in 247 second(s)

Without this patch

Executed 78213 test(s) (78213 passed, 0 expected failures, 0 failed, 0 crashed, 0 disabled) in 258 second(s)

@gunes-arm
Copy link
Contributor

Thanks for checking the number of tests. Can you check for --mode=ALL? You only need to list the tests, not run, i.e.

./arm_compute_validation --mode=ALL --list-tests | wc -l

@morgolock
Copy link
Contributor Author

Thanks for checking the number of tests. Can you check for --mode=ALL? You only need to list the tests, not run, i.e.

./arm_compute_validation --mode=ALL --list-tests | wc -l

Both cases I get

130|shiba:/data/local/tmp/pabtel01 $ ./arm_compute_validation  --mode=ALL --list-tests | wc -l                                                                                        
425731

Signed-off-by: Pablo Marquez Tello <pablo.tello@arm.com>
Change-Id: I976e01b9be9ee91f7de09f050392576133d1e929
@morgolock morgolock force-pushed the pr/flatten_nested_combine branch from 308671f to 96d6ee2 Compare October 23, 2025 08:52
@gunes-arm gunes-arm self-requested a review October 23, 2025 11:53
Copy link
Contributor

@gunes-arm gunes-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright years did not change

@morgolock morgolock closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants