lp ticker - fix doc for sleep and set interrupt #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not clear what is the intention with now and the time. Because there are various timers (counter running up with matching interrupt, or a timer with deltas (from a value count down to 0)). This should clarify what is expected to do, our tests can test this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had various questions about this 2 functions, which led me to check targets implementations and found various things (more here ARMmbed/minar-platform-mbed#17).
It was not clear what is the intention with now and the time. Because
there are various timers (counter running up with matching interrupt, or
a timer with deltas (from a value count down to 0)). This should
clarify what is expected to do, our tests can test this.
@autopulated @bogdanm @marcuschangarm