[PS] DnsReolver module migration autorest v4 breaking change announcement #28698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
dolauli
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Az.DnsResolver module to add preannounced breaking change warnings for upcoming changes in Az v16.0.0 (May 2026). The changes include adding preview announcements to specific cmdlets, updating module dependencies, and general maintenance updates.
- Adds breaking change preview announcements to specific DnsResolver cmdlets
- Updates Az.Accounts dependency from version 4.0.1 to 5.3.0
- Adds DnsResolver module mapping configuration
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/CreateMappings_rules.json | Adds DnsResolver module to the module mapping configuration |
| src/DnsResolver/DnsResolver/ChangeLog.md | Documents breaking change preannouncement in upcoming release notes |
| src/DnsResolver/DnsResolver/Az.DnsResolver.psd1 | Updates module metadata including Az.Accounts dependency and generation date |
| src/DnsResolver/DnsResolver.sln | Reorganizes solution structure with new build configurations for x64/x86 platforms and updates project GUIDs |
| src/DnsResolver/DnsResolver.Autorest/resources/README.md | Adds new resources directory documentation |
| src/DnsResolver/DnsResolver.Autorest/generate-info.json | Updates generation ID for the AutoRest-generated code |
| src/DnsResolver/DnsResolver.Autorest/docs/Az.DnsResolver.md | Updates module GUID in documentation |
| src/DnsResolver/DnsResolver.Autorest/README.md | Adds preview-announcement directive for affected cmdlets and removes erroneous first line |
| src/DnsResolver/DnsResolver.Autorest/Properties/AssemblyInfo.cs | Adds new assembly metadata file |
Comments suppressed due to low confidence (1)
src/DnsResolver/DnsResolver.Autorest/README.md:1
- The file starts with a stray 'v' character that should be removed.
v
Comment on lines
+126
to
+131
| - where: | ||
| verb: Get|New|Update | ||
| subject: DnsForwardingRuleset|ForwardingRule|DnsResolverDomainList|InboundEndpoint|PolicyDnsSecurityRule | ||
| set: | ||
| preview-announcement: | ||
| preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v16.0.0, to be released in May 2026. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************" |
There was a problem hiding this comment.
The preview-announcement directive is missing a comment explaining its purpose. According to the AutoRest README.md guidelines, all directives should have comments explaining why they exist. Add a comment above this directive explaining that it notifies users about upcoming breaking changes in Az v16.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.